[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <184e4080-ff02-4d75-be35-ab49f61dbd3d@oracle.com>
Date: Tue, 2 Sep 2025 16:09:23 +0100
From: John Garry <john.g.garry@...cle.com>
To: Ojaswin Mujoo <ojaswin@...ux.ibm.com>, Zorro Lang <zlang@...hat.com>,
fstests@...r.kernel.org
Cc: Ritesh Harjani <ritesh.list@...il.com>, djwong@...nel.org, tytso@....edu,
linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-ext4@...r.kernel.org
Subject: Re: [PATCH v5 05/12] generic: Add atomic write test using fio crc
check verifier
On 22/08/2025 09:02, Ojaswin Mujoo wrote:
> This adds atomic write test using fio based on it's crc check verifier.
> fio adds a crc header for each data block, which is verified later to
> ensure there is no data corruption or torn write.
>
> This test essentially does a lot of parallel RWF_ATOMIC IO on a
> preallocated file to stress the write and end-io unwritten conversion
> code paths. The idea is to increase code coverage to ensure RWF_ATOMIC
> hasn't introduced any issues.
>
> Avoid doing overlapping parallel atomic writes because it might give
> unexpected results. Use offset_increment=, size= fio options to achieve
> this behavior.
>
> Co-developed-by: Ritesh Harjani (IBM)<ritesh.list@...il.com>
> Signed-off-by: Ritesh Harjani (IBM)<ritesh.list@...il.com>
> Reviewed-by: Darrick J. Wong<djwong@...nel.org>
> Signed-off-by: Ojaswin Mujoo<ojaswin@...ux.ibm.com>
I am still a bit skeptical of the value of this test, but here is my tag
anyway:
Reviewed-by: John Garry <john.g.garry@...cle.com>
Powered by blists - more mailing lists