linux-kernel - Re: [PATCH] platform/x86/amd/pmc: Add Stellaris Slim Gen6 AMD to spurious 8042 quirks list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f33c919-571b-45b7-b2bb-c755b4195035@kernel.org>
Date: Tue, 2 Sep 2025 10:25:20 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Werner Sembach <wse@...edocomputers.com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>, Hans de Goede
 <hansg@...nel.org>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, Christoffer Sandberg <cs@...edo.de>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86/amd/pmc: Add Stellaris Slim Gen6 AMD to
 spurious 8042 quirks list

On 9/2/2025 9:37 AM, Werner Sembach wrote:
> 
> Am 02.09.25 um 16:15 schrieb Mario Limonciello:
>> On 9/1/2025 11:42 AM, Werner Sembach wrote:
>>> From: Christoffer Sandberg <cs@...edo.de>
>>>
>>> Prevents instant wakeup ~1s after suspend
>>>
>>> Signed-off-by: Christoffer Sandberg <cs@...edo.de>
>>> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
>>> ---
>>>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/ 
>>> platform/x86/amd/pmc/pmc-quirks.c
>>> index 7ffc659b27944..8b8944483b859 100644
>>> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
>>> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
>>> @@ -248,6 +248,13 @@ static const struct dmi_system_id fwbug_list[] = {
>>>               DMI_MATCH(DMI_PRODUCT_NAME, "Lafite Pro V 14M"),
>>>           }
>>>       },
>>> +    {
>>> +        .ident = "TUXEDO Stellaris Slim 15 AMD Gen6",
>>> +        .driver_data = &quirk_spurious_8042,
>>> +        .matches = {
>>> +            DMI_MATCH(DMI_BOARD_NAME, "GMxHGxx"),
>>> +        }
>>> +    },
>>>       {}
>>>   };
>>
>> FYI - this seems to conflict with other changes on review-ilpo-fixes 
>> and fixes branches.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform- 
>> drivers-x86.git/commit/drivers/platform/x86/amd/pmc/pmc-quirks.c? 
>> h=review-ilpo-fixes&id=c96f86217bb28e019403bb8f59eacd8ad5a7ad1a
> Sorry, i will rebase and send a v2.
>>
>> Also - a few other comments.
>>
>> 1) Do you have line of sight to a firmware (BIOS or EC) fix?  If so; 
>> it would be better to specify a specific firmware release that is 
>> affected.
> 
> No
> 
> @Christoffer you have more knowledge of how realistic it is to get this 
> fixed by the odm?

OK, even if you don't get a solution in the firmware in this generation 
it's good to understand this issue and root cause it so that you can 
have it fixed properly next generation.

It's not always realistic but ideally bringing a new product to market 
shouldn't require a quirk.

> 
> But even then, we still don't have fwupd support to get the fw update 
> out easily
> 

😢

>>
>> 2) Shouldn't you also have DMI_SYS_VENDOR or some other matching keys 
>> else set?  Or is it really all these boards with this specific name?
> 
> I was following the style of the i8042 quirk list where we also always 
> only did boardnames
> 
> Ofc we only tested the boards the odm has sent to us
> 
> best regards,
> 
> Werner Sembach
> 

But this isn't a hardware problem with the board itself, it's a firmware 
problem.  The board ID you're using is just a convenient proxy for it.

I've seen the debugging for a few issues like this and it can be all 
across the board.  A few examples:

* polarity issues
* debounce issues
* incorrectly set PCD (Kinda like a Kconfig for BIOS)