linux-kernel - Re: [BUG] x86/mm: regression after 4a02ed8e1cc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <913a509d-d985-4520-a879-538a1198b946@intel.com>
Date: Tue, 2 Sep 2025 08:50:42 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
 Rik van Riel <riel@...riel.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, bp@...en8.de,
 peterz@...radead.org, dave.hansen@...ux.intel.com,
 zhengqi.arch@...edance.com, nadav.amit@...il.com, thomas.lendacky@....com,
 kernel-team@...a.com, linux-mm@...ck.org, akpm@...ux-foundation.org,
 jackmanb@...gle.com, jannh@...gle.com, mhklinux@...look.com,
 andrew.cooper3@...rix.com, Manali.Shukla@....com, mingo@...nel.org,
 baolu.lu@...el.com, david.guckian@...el.com, damian.muszynski@...el.com
Subject: Re: [BUG] x86/mm: regression after 4a02ed8e1cc3

On 9/2/25 08:44, Giovanni Cabiddu wrote:
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 39f80111e6f1..e66c7662c254 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -1459,7 +1459,7 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
>  
>  	put_flush_tlb_info();
>  	put_cpu();
> -	mmu_notifier_arch_invalidate_secondary_tlbs(mm, start, end);
> +	mmu_notifier_arch_invalidate_secondary_tlbs(mm, info->start, info->end);
>  }

That does look like the right solution.

This is the downside of wrapping everything up in that 'info' struct;
it's not obvious that the canonical source of the start/end information
moved from those variables into the structure.

Rik, is that your read on it too?

In any case, Giovanni, do you want to send that as a "real" patch that
we can apply (changelog, SoB, Fixes, Cc:stable@, etc...)?