linux-kernel - Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68b71329c4f86_4bae5294d3@iweiny-mobl.notmuch>
Date: Tue, 2 Sep 2025 10:54:17 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Colin Ian King <colin.i.king@...il.com>, Dan Williams
	<dan.j.williams@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, "Dave
 Jiang" <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>, "Rafael J .
 Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, Jia He
	<justin.he@....com>, <nvdimm@...ts.linux.dev>, <linux-acpi@...r.kernel.org>
CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being
 reportedin dev_err message

Colin Ian King wrote:
> There appears to be a cut-n-paste error with the incorrect field

NIT: 'There __is__ a cut-n-paste error..."  ;-)

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

> ndr_desc->numa_node being reported for the target node. Fix this by
> using ndr_desc->target_node instead.
> 
> Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/acpi/nfit/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index ae035b93da08..3eb56b77cb6d 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
>  	if (ndr_desc->target_node == NUMA_NO_NODE) {
>  		ndr_desc->target_node = phys_to_target_node(spa->address);
>  		dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> -			NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> +			NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
>  	}
>  
>  	/*
> -- 
> 2.51.0
>