linux-kernel - Re: [PATCH 1/3] fs: add an enum for number of life time hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e844fe01-7cfa-4aff-b21e-d0ad04399829@acm.org>
Date: Tue, 2 Sep 2025 09:12:24 -0700
From: Bart Van Assche <bvanassche@....org>
To: hch <hch@....de>, Hans Holmberg <Hans.Holmberg@....com>
Cc: "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
 Carlos Maiolino <cem@...nel.org>, Dave Chinner <david@...morbit.com>,
 "Darrick J . Wong" <djwong@...nel.org>,
 "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 axboe@...nel.dk
Subject: Re: [PATCH 1/3] fs: add an enum for number of life time hints

On 9/1/25 10:41 PM, hch wrote:
> Looks good, but you probably want to add a few more folks that
> created this constant and the header to the Cc list.
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> On Mon, Sep 01, 2025 at 10:52:04AM +0000, Hans Holmberg wrote:
>> Add WRITE_LIFE_HINT_NR into the rw_hint enum to define the number of
>> values write life time hints can be set to. This is useful for e.g.
>> file systems which may want to map these values to allocation groups.
>>
>> Signed-off-by: Hans Holmberg <hans.holmberg@....com>
>> ---
>>   include/linux/rw_hint.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/rw_hint.h b/include/linux/rw_hint.h
>> index 309ca72f2dfb..adcc43042c90 100644
>> --- a/include/linux/rw_hint.h
>> +++ b/include/linux/rw_hint.h
>> @@ -14,6 +14,7 @@ enum rw_hint {
>>   	WRITE_LIFE_MEDIUM	= RWH_WRITE_LIFE_MEDIUM,
>>   	WRITE_LIFE_LONG		= RWH_WRITE_LIFE_LONG,
>>   	WRITE_LIFE_EXTREME	= RWH_WRITE_LIFE_EXTREME,
>> +	WRITE_LIFE_HINT_NR,
>>   } __packed;
>>   
>>   /* Sparse ignores __packed annotations on enums, hence the #ifndef below. */
>> -- 
>> 2.34.1
> ---end quoted text---

Thanks Christoph for having Cc-ed me. I'm not a big fan of this type of
change because it makes it harder to write switch-statements without
'default:' clause. From a quick look I haven't found any such
switch-statements on 'enum rw_hint' so I'm fine with this change.

Bart.