linux-kernel - Re: [PATCH] watchdog: mpc8xxx_wdt: Reload the watchdog timer when enabling the watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16b6cc01-90bc-42cb-936a-d0a20266e4a3@roeck-us.net>
Date: Tue, 2 Sep 2025 09:18:02 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: mpc8xxx_wdt: Reload the watchdog timer when
 enabling the watchdog

On 8/12/25 05:51, Christophe Leroy wrote:
> When the watchdog gets enabled with this driver, it leaves enough time
> for the core watchdog subsystem to start pinging it. But when the
> watchdog is already started by hardware or by the boot loader, little
> time remains before it fires and it happens that the core watchdog
> subsystem doesn't have time to start pinging it.
> 
> Until commit 19ce9490aa84 ("watchdog: mpc8xxx: use the core worker
> function") pinging was managed by the driver itself and the watchdog
> was immediately pinged by setting the timer expiry to 0.
> 
> So restore similar behaviour by pinging it when enabling it so that
> if it was already enabled the watchdog timer counter is reloaded.
> 
> Fixes: 19ce9490aa84 ("watchdog: mpc8xxx: use the core worker function")
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>


Reviewed-by: Guenter Roeck <linux@...ck-us.net>