linux-kernel - Re: [PATCH v9 3/3] SPI: Add virtio SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92d07f3f-8416-4b54-ac6f-c6e46869fd53@sirena.org.uk>
Date: Tue, 2 Sep 2025 17:28:28 +0100
From: Mark Brown <broonie@...nel.org>
To: Harald Mommer <harald.mommer@....qualcomm.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>,
	Haixu Cui <quic_haixcui@...cinc.com>, quic_msavaliy@...cinc.com,
	virtio-dev@...ts.linux.dev, viresh.kumar@...aro.org,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	hdanton@...a.com, qiang4.zhang@...ux.intel.com,
	alex.bennee@...aro.org, quic_ztu@...cinc.com,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v9 3/3] SPI: Add virtio SPI driver

On Tue, Sep 02, 2025 at 05:54:39PM +0200, Harald Mommer wrote:

> I'm not aware of a requirement in the style guide for the Linux kernel
> that all used headers have to be included directly in the C file but
> this does not mean that such a requirement does not exist. Can anyone
> point my nose on it?

It's a general best practice for maintainability, I'm not aware of
anywhere where it's specifically written down but it's something people
commonly try to do.  That said so long as things compile I'm not going
to block anything on this sort of extremely pedantic review, especially
at this late stage in review.  I would have a lot more time for patches
for such issues, this is rather stop energy.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)