linux-kernel - Re: [PATCH] rust: kasan/kbuild: fix missing flags on first build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250902-gown-relapse-8fd3978c1ea0@spud>
Date: Tue, 2 Sep 2025 17:35:46 +0100
From: Conor Dooley <conor@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Andrey Ryabinin <ryabinin.a.a@...il.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org,
	Alexander Potapenko <glider@...gle.com>,
	Andrey Konovalov <andreyknvl@...il.com>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	Vincenzo Frascino <vincenzo.frascino@....com>,
	kasan-dev@...glegroups.com, Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
	Matthew Maurer <mmaurer@...gle.com>,
	Sami Tolvanen <samitolvanen@...gle.com>, stable@...r.kernel.org
Subject: Re: [PATCH] rust: kasan/kbuild: fix missing flags on first build

> > AFAICT. Then later on it'd become more like:
> >
> > config HAVE_CFI_ICALL_NORMALIZE_INTEGERS_RUSTC
> >         def_bool y
> >         depends on HAVE_CFI_ICALL_NORMALIZE_INTEGERS_CLANG
> >         depends on RISCV || ((ARM64 || x86_64) && RUSTC_VERSION >= 107900)
> >         depends on (ARM64 || x86_64) || (RISCV && RUSTC_VERSION >= 999999)
> >         # With GCOV/KASAN we need this fix: https://github.com/rust-lang/rust/pull/129373
> >         depends on (RUSTC_LLVM_VERSION >= 190103 && RUSTC_VERSION >= 108200) || \
> >                 (!GCOV_KERNEL && !KASAN_GENERIC && !KASAN_SW_TAGS)
> >
> > but that exact sort of mess is what becomes unwieldy fast since that
> > doesn't even cover 32-bit arm.
> 
> I think a better way of writing it is like this:
> 
> depends on ARCH1 || ARCH2 || ARCH3
> depends on !ARCH1 || RUSTC_VERSION >= 000000
> depends on !ARCH2 || RUSTC_VERSION >= 000000
> depends on !ARCH3 || RUSTC_VERSION >= 000000


Ye, that's a lot more manageable than what I came up with, shoulda
really done better since the option I used for a reference looks a lot
more like this than what I had... Thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)