linux-kernel - Re: [PATCH 1/4] sparc: fix accurate exception reporting in copy_{from_to}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250902.183348.7850037982207673.rene@exactcode.com>
Date: Tue, 02 Sep 2025 18:33:48 +0200 (CEST)
From: Rene Rebe <rene@...ctcode.com>
To: kernel@...rcher.dialup.fu-berlin.de
Cc: linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
 andreas@...sler.com, glaubitz@...sik.fu-berlin.de,
 anthony.yznaga@...cle.com
Subject: Re: [PATCH 1/4] sparc: fix accurate exception reporting in
 copy_{from_to}_user for UltraSPARC

Hi Michael, Adrian,

thank you so much for doing this work and dropping me a note to test!
I had bisected that last year, too, but due to lack of further time
only ended up reverting d563d678aa0 "fs: Handle intra-page faults in
copy_mount_options()". I also did not suspect copy_{from,to}_user be
that regressed and broken on sparc64, ... :-/

Tested-by: René Rebe <rene@...ctcode.com> # on Ultra 5 UltraSparc IIi

> Fixes: cb736fdbb208 ("sparc64: Convert U1copy_{from,to}_user to accurate exception reporting.")
> Signed-off-by: Michael Karcher <kernel@...rcher.dialup.fu-berlin.de>
> ---
>  arch/sparc/lib/U1memcpy.S | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/sparc/lib/U1memcpy.S b/arch/sparc/lib/U1memcpy.S
> index 635398ec7540..154fbd35400c 100644
> --- a/arch/sparc/lib/U1memcpy.S
> +++ b/arch/sparc/lib/U1memcpy.S
> @@ -164,17 +164,18 @@ ENTRY(U1_gs_40_fp)
>  	retl
>  	 add		%o0, %o2, %o0
>  ENDPROC(U1_gs_40_fp)
> -ENTRY(U1_g3_0_fp)
> -	VISExitHalf
> -	retl
> -	 add		%g3, %o2, %o0
> -ENDPROC(U1_g3_0_fp)
>  ENTRY(U1_g3_8_fp)
>  	VISExitHalf
>  	add		%g3, 8, %g3
>  	retl
>  	 add		%g3, %o2, %o0
>  ENDPROC(U1_g3_8_fp)
> +ENTRY(U1_g3_16_fp)
> +	VISExitHalf
> +	add		%g3, 16, %g3
> +	retl
> +	 add		%g3, %o2, %o0
> +ENDPROC(U1_g3_16_fp)
>  ENTRY(U1_o2_0_fp)
>  	VISExitHalf
>  	retl
> @@ -547,18 +548,18 @@ FUNC_NAME:		/* %o0=dst, %o1=src, %o2=len */
>  62:	FINISH_VISCHUNK(o0, f44, f46)
>  63:	UNEVEN_VISCHUNK_LAST(o0, f46, f0)
>  
> -93:	EX_LD_FP(LOAD(ldd, %o1, %f2), U1_g3_0_fp)
> +93:	EX_LD_FP(LOAD(ldd, %o1, %f2), U1_g3_8_fp)
>  	add		%o1, 8, %o1
>  	subcc		%g3, 8, %g3
>  	faligndata	%f0, %f2, %f8
> -	EX_ST_FP(STORE(std, %f8, %o0), U1_g3_8_fp)
> +	EX_ST_FP(STORE(std, %f8, %o0), U1_g3_16_fp)
>  	bl,pn		%xcc, 95f
>  	 add		%o0, 8, %o0
> -	EX_LD_FP(LOAD(ldd, %o1, %f0), U1_g3_0_fp)
> +	EX_LD_FP(LOAD(ldd, %o1, %f0), U1_g3_8_fp)
>  	add		%o1, 8, %o1
>  	subcc		%g3, 8, %g3
>  	faligndata	%f2, %f0, %f8
> -	EX_ST_FP(STORE(std, %f8, %o0), U1_g3_8_fp)
> +	EX_ST_FP(STORE(std, %f8, %o0), U1_g3_16_fp)
>  	bge,pt		%xcc, 93b
>  	 add		%o0, 8, %o0
>  
> -- 
> 2.50.1
> 
> 

-- 
  René Rebe, ExactCODE GmbH, Berlin, Germany.
  https://exactcode.com | https://t2linux.com | https://rene.rebe.de