linux-kernel - Re: [PATCH] Documentation: dev-tools: Fix a typo in autofdo documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF1bQ=TB6KMAkwXfEF=ZJvJZqV8B9kEw3jbVMG4gRoLOUjksiA@mail.gmail.com>
Date: Tue, 2 Sep 2025 09:50:05 -0700
From: Rong Xu <xur@...gle.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, Han Shen <shenhan@...gle.com>, 
	Jonathan Corbet <corbet@....net>, workflows@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: dev-tools: Fix a typo in autofdo documentation

Thanks for the fix! I meant to include "/" in the original patch, but
I overlooked it.

Reviewed-by: Rong Xu <xur@...gle.com>

On Tue, Sep 2, 2025 at 6:03 AM Harshit Mogalapalli
<harshit.m.mogalapalli@...cle.com> wrote:
>
> Hi Geert,
>
> On 02/09/25 12:43, Geert Uytterhoeven wrote:
> > Hi Harshit,
> >
> > On Mon, 1 Sept 2025 at 17:57, Harshit Mogalapalli
> > <harshit.m.mogalapalli@...cle.com> wrote:
> >> Use cat /proc/cpuinfo as opposed cat proc/cpuinfo.
> >>
> >> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> >
> > Thanks for your patch!
> >
> >> --- a/Documentation/dev-tools/autofdo.rst
> >> +++ b/Documentation/dev-tools/autofdo.rst
> >> @@ -131,11 +131,11 @@ Here is an example workflow for AutoFDO kernel:
> >>
> >>        For Zen3::
> >>
> >> -      $ cat proc/cpuinfo | grep " brs"
> >> +      $ cat /proc/cpuinfo | grep " brs"
> >>
> >>        For Zen4::
> >>
> >> -      $ cat proc/cpuinfo | grep amd_lbr_v2
> >> +      $ cat /proc/cpuinfo | grep amd_lbr_v2
> >>
> >>        The following command generated the perf data file::
> >>
> >
> > One might say the path depends on where the proc filesystem is mounted ;-)
> > However, all other documentation (except for two occurrences in
> > Documentation/networking/proc_net_tcp.rst, which you may want to fix,
> > too) assumes /proc, so it is better to be consistent.
> >
>
> Oh very good point, yes I did check other instances and thought we make
> it consistent.
>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> >
>
> Thanks a lot for the review.
>
>
> Regards,
> Harshit
>
> > Gr{oetje,eeting}s,
> >
> >                          Geert
> >
>