linux-kernel - Re: [PATCH v5 13/20] x86/mce: Unify AMD THR handler with MCA Polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250902170438.GGaLcjpoEhdfAGtBph@fat_crate.local>
Date: Tue, 2 Sep 2025 19:04:38 +0200
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: x86@...nel.org, Tony Luck <tony.luck@...el.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	Smita.KoralahalliChannabasappa@....com,
	Qiuxu Zhuo <qiuxu.zhuo@...el.com>,
	Nikolay Borisov <nik.borisov@...e.com>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v5 13/20] x86/mce: Unify AMD THR handler with MCA Polling

On Tue, Sep 02, 2025 at 09:37:13AM -0400, Yazen Ghannam wrote:
> This means we'd need to do another loop through the banks. Their
> MCi_STATUS registers would be cleared. So they could log another error
> before the limit is reset.
> 
> Overall, the goal is to loop through the banks one time and log/reset
> banks as we go through them.

Is there anything special about keeping this looping once? I might've missed
the reason if there were any particular one...

In any case, it sounds to me like you want a wrapper called

	clear_bank(i)

which executes at the end of machine_check_poll() and hides in there all
the possible MCA banks that need to be touched when done with the bank.

It'll still call back'n'forth through the code but at least all will be nicely
abstracted and concentrated.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette