linux-kernel - Re: [PATCH 1/3] dt-bindings: iio: adc: ROHM BD79112 ADC/GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175683578289.936608.3477668195039989719.robh@kernel.org>
Date: Tue, 02 Sep 2025 12:57:27 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>, 
 Javier Carrasco <javier.carrasco.cruz@...il.com>, 
 Ramona Alexandra Nechita <ramona.nechita@...log.com>, 
 David Lechner <dlechner@...libre.com>, 
 Matti Vaittinen <matti.vaittinen@...rohmeurope.com>, 
 Marcelo Schmitt <marcelo.schmitt@...log.com>, 
 Nuno Sá <nuno.sa@...log.com>, 
 Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, 
 Antoniu Miclaus <antoniu.miclaus@...log.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, 
 Hans de Goede <hansg@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
 Thomas Bonnefille <thomas.bonnefille@...tlin.com>, 
 Tobias Sperling <tobias.sperling@...ting.com>, 
 Conor Dooley <conor+dt@...nel.org>, Trevor Gamblin <tgamblin@...libre.com>, 
 devicetree@...r.kernel.org, Esteban Blanc <eblanc@...libre.com>, 
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: ROHM BD79112 ADC/GPIO


On Tue, 02 Sep 2025 15:23:54 +0300, Matti Vaittinen wrote:
> The ROHM BD79112 is an ADC/GPIO with 32 channels. The channel inputs can
> be used as ADC or GPIO. Using the GPIOs as IRQ sources isn't supported.
> 
> The ADC is 12-bit, supporting input voltages up to 5.7V, and separate I/O
> voltage supply. Maximum SPI clock rate is 20 MHz (10 MHz with
> daisy-chain configuration) and maximum sampling rate is 1MSPS.
> 
> Add a device tree binding document for the ROHM BD79112.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> ---
>  .../bindings/iio/adc/rohm,bd79112.yaml        | 118 ++++++++++++++++++
>  1 file changed, 118 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.example.dtb: adc@0 (rohm,bd79112): '#gpio-cells' is a dependency of 'gpio-controller'
	from schema $id: http://devicetree.org/schemas/gpio/gpio.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/77c36ecaf5992ebcabf6ce862bf2a6ec72d9f606.1756813980.git.mazziesaccount@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.