linux-kernel - Re: [PATCH] mtd: spi-nor: issi: Add support for is25wx01g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250902183818.17415-1-flaviu.nistor@gmail.com>
Date: Tue,  2 Sep 2025 21:38:18 +0300
From: Flaviu Nistor <flaviu.nistor@...il.com>
To: Pratyush Yadav <pratyush@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>,
	Michael Walle <mwalle@...nel.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>,
	linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	flaviu.nistor@...il.com
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25wx01g

> Hi Flaviu,
>
> On Mon, Sep 01 2025, Flaviu Nistor wrote:
>
>> Add support for the IS25WX01G 128MB (1Gb) ISSI Serial Flash Memory.
>>
>> Signed-off-by: Flaviu Nistor <flaviu.nistor@...il.com>
>> ---
>>  drivers/mtd/spi-nor/issi.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
>> index 18d9a00aa22e..e4997f9bd557 100644
>> --- a/drivers/mtd/spi-nor/issi.c
>> +++ b/drivers/mtd/spi-nor/issi.c
>> @@ -126,6 +126,9 @@ static const struct flash_info issi_nor_parts[] = {
>>  		.flags = SPI_NOR_QUAD_PP,
>>  		.fixups = &is25lp256_fixups,
>>  		.fixup_flags = SPI_NOR_4B_OPCODES,
>> +	}, {
>> +		/* IS25WX01G */
>> +		.id = SNOR_ID(0x9d, 0x5b, 0x1b),
>
> It seems the flash needs no special configuration. IIUC it can be driven
> entirely based on SFDP data. In that case, I don't think there is a need
> for an entry at all. The generic SFDP-based driver should already be
> enough for your flash. Just add a "jedec,spi-nor" node to your DT and it
> should work.

Thanks for the review and the explanation. I now see in
the core driver that spi_nor_check_sfdp_signature() is
used if spi_nor_match_id() does not find a valid entry.

>
>>  	}
>>  };