linux-kernel - Re: [PATCH 01/12] maple_tree: Fix check_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd2804ce-2d81-4a39-9623-32fb2fbf5351@oracle.com>
Date: Tue, 2 Sep 2025 15:36:22 -0400
From: Sidhartha Kumar <sidhartha.kumar@...cle.com>
To: Vlastimil Babka <vbabka@...e.cz>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Matthew Wilcox <willy@...radead.org>,
        Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
        Jann Horn <jannh@...gle.com>, Pedro Falcato <pfalcato@...e.de>,
        Suren Baghdasaryan <surenb@...gle.com>
Cc: Harry Yoo <harry.yoo@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/12] maple_tree: Fix check_bulk_rebalance() test locks

On 9/1/25 7:08 AM, Vlastimil Babka wrote:
> From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
> 
> The check_bulk_rebalance() test was not correctly locking the tree which
> caused issues with the sheaves testing in later patches.  Adding the
> missing locks fixed the issue.
> 
> Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>

If needed,

Fixes: a6e0ceb7bf48 ("maple_tree: check for MA_STATE_BULK on setting 
wr_rebalance")

Reviewed-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>

> ---
>   tools/testing/radix-tree/maple.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> index 172700fb7784d29f9403003b4484a5ebd7aa316b..159d5307b30a4b37e6cf2941848b8718e1b891d9 100644
> --- a/tools/testing/radix-tree/maple.c
> +++ b/tools/testing/radix-tree/maple.c
> @@ -36465,6 +36465,7 @@ static inline void check_bulk_rebalance(struct maple_tree *mt)
>   
>   	build_full_tree(mt, 0, 2);
>   
> +	mas_lock(&mas);
>   	/* erase every entry in the tree */
>   	do {
>   		/* set up bulk store mode */
> @@ -36474,6 +36475,7 @@ static inline void check_bulk_rebalance(struct maple_tree *mt)
>   	} while (mas_prev(&mas, 0) != NULL);
>   
>   	mas_destroy(&mas);
> +	mas_unlock(&mas);
>   }
>   
>   void farmer_tests(void)
>