linux-kernel - Re: [PATCH v2 2/2] selftests/mm: split_huge_page_test: cleanups for split_pte_mapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250902200036.6mv4wqenbnjir277@master>
Date: Tue, 2 Sep 2025 20:00:36 +0000
From: Wei Yang <richard.weiyang@...il.com>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-kselftest@...r.kernel.org, Zi Yan <ziy@...dia.com>
Subject: Re: [PATCH v2 2/2] selftests/mm: split_huge_page_test: cleanups for
 split_pte_mapped_thp test

On Tue, Sep 02, 2025 at 06:25:36PM +0200, David Hildenbrand wrote:
>There is room for improvement, so let's clean up a bit:
>
>(1) Define "4" as a constant.
>
>(2) SKIP if we fail to allocate all THPs (e.g., fragmented) and add
>    recovery code for all other failure cases: no need to exit the test.
>
>(3) Rename "len" to thp_area_size, and "one_page" to "thp_area".
>
>(4) Allocate a new area "page_area" into which we will mremap the
>    pages; add "page_area_size". Now we can easily merge the two
>    mremap instances into a single one.
>
>(5) Iterate THPs instead of bytes when checking for missed THPs after
>    mremap.
>
>(6) Rename "pte_mapped2" to "tmp", used to verify mremap(MAP_FIXED)
>    result.
>
>(7) Split the corruption test from the failed-split test, so we can just
>    iterate bytes vs. thps naturally.
>
>(8) Extend comments and clarify why we are using mremap in the first
>    place.
>
>Reviewed-by: Zi Yan <ziy@...dia.com>
>Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Wei Yang <richard.weiyang@...il.com>

-- 
Wei Yang
Help you, Help me