linux-kernel - Re: [PATCH v5] HID: lg-g15 - Add support for Logitech G13.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9600871d-7a68-4e7e-8cc1-5280af554378@kernel.org>
Date: Tue, 2 Sep 2025 22:47:48 +0200
From: Hans de Goede <hansg@...nel.org>
To: kernel test robot <lkp@...el.com>, "Leo L. Schwab" <ewhac@...ac.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
 Kate Hsuan <hpa@...hat.com>, Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] HID: lg-g15 - Add support for Logitech G13.

Hi,

On 2-Sep-25 21:46, kernel test robot wrote:
> Hi Leo,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on hid/for-next]
> [also build test ERROR on linus/master v6.17-rc4 next-20250902]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Leo-L-Schwab/HID-lg-g15-Add-support-for-Logitech-G13/20250902-091504
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
> patch link:    https://lore.kernel.org/r/20250902003659.361934-2-ewhac%40ewhac.org
> patch subject: [PATCH v5] HID: lg-g15 - Add support for Logitech G13.
> config: i386-buildonly-randconfig-006-20250902 (https://download.01.org/0day-ci/archive/20250903/202509030200.ITZPZGmG-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250903/202509030200.ITZPZGmG-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509030200.ITZPZGmG-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/hid/hid-lg-g15.c:692:30: error: no member named 'brightness_hw_changed' in 'struct led_classdev'
>      692 |                                            ^ (g15->leds[0].cdev.brightness_hw_changed > 0);
>          |                                               ~~~~~~~~~~~~~~~~~ ^
>    1 error generated.

Ah right, IS_ENABLED() only helps to avoid errors about references which
are resolved link-time and this is a compile-time issue.

But as discussed in the v3 thread we don't want to use 
cdev.brightness_hw_changed anyways.

Regards,

Hans


> 
> vim +692 drivers/hid/hid-lg-g15.c
> 
>    655	
>    656	static int lg_g13_event(struct lg_g15_data *g15, u8 const *data)
>    657	{
>    658		struct g13_input_report const * const rep = (struct g13_input_report *) data;
>    659		int i, val;
>    660	
>    661		/*
>    662		 * Main macropad and menu keys.
>    663		 * Emit key events defined for each bit position.
>    664		 */
>    665		for (i = 0; i < ARRAY_SIZE(g13_keys_for_bits); ++i) {
>    666			if (g13_keys_for_bits[i]) {
>    667				val = TEST_BIT(rep->keybits, i);
>    668				input_report_key(g15->input, g13_keys_for_bits[i], val);
>    669			}
>    670		}
>    671		input_sync(g15->input);
>    672	
>    673		/*
>    674		 * Joystick.
>    675		 * Emit button and deflection events.
>    676		 */
>    677		for (i = 0; i < ARRAY_SIZE(g13_keys_for_bits_js); ++i) {
>    678			val = TEST_BIT(rep->keybits, i + G13_JS_KEYBITS_OFFSET);
>    679			input_report_key(g15->input_js, g13_keys_for_bits_js[i], val);
>    680		}
>    681		input_report_abs(g15->input_js, ABS_X, rep->joy_x);
>    682		input_report_abs(g15->input_js, ABS_Y, rep->joy_y);
>    683		input_sync(g15->input_js);
>    684	
>    685		if (IS_ENABLED(CONFIG_LEDS_BRIGHTNESS_HW_CHANGED)) {
>    686			/*
>    687			 * Bit 23 of keybits[] reports the current backlight on/off
>    688			 * state.  If it has changed from the last cached value, apply
>    689			 * an update.
>    690			 */
>    691			bool hw_brightness_changed = (!!TEST_BIT(rep->keybits, 23))
>  > 692						   ^ (g15->leds[0].cdev.brightness_hw_changed > 0);
>    693			if (hw_brightness_changed)
>    694				led_classdev_notify_brightness_hw_changed(
>    695					&g15->leds[0].cdev,
>    696					TEST_BIT(rep->keybits, 23) ? LED_FULL : LED_OFF);
>    697		}
>    698	
>    699		return 0;
>    700	}
>    701	
>