linux-kernel - Re: [PATCH v9 06/11] firmware: qcom: scm: add support for object invocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509030554.WR3MNpCE-lkp@intel.com>
Date: Wed, 3 Sep 2025 05:35:05 +0800
From: kernel test robot <lkp@...el.com>
To: Amirreza Zarrabi <amirreza.zarrabi@....qualcomm.com>,
	Jens Wiklander <jens.wiklander@...aro.org>,
	Sumit Garg <sumit.garg@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Apurupa Pattapu <quic_apurupa@...cinc.com>,
	Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Christian König <christian.koenig@....com>
Cc: oe-kbuild-all@...ts.linux.dev, Harshal Dev <quic_hdev@...cinc.com>,
	linux-arm-msm@...r.kernel.org, op-tee@...ts.trustedfirmware.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
	linux-doc@...r.kernel.org,
	Amirreza Zarrabi <amirreza.zarrabi@....qualcomm.com>,
	Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v9 06/11] firmware: qcom: scm: add support for object
 invocation

Hi Amirreza,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 33bcf93b9a6b028758105680f8b538a31bc563cf]

url:    https://github.com/intel-lab-lkp/linux/commits/Amirreza-Zarrabi/tee-allow-a-driver-to-allocate-a-tee_device-without-a-pool/20250902-125821
base:   33bcf93b9a6b028758105680f8b538a31bc563cf
patch link:    https://lore.kernel.org/r/20250901-qcom-tee-using-tee-ss-without-mem-obj-v9-6-a2af23f132d5%40oss.qualcomm.com
patch subject: [PATCH v9 06/11] firmware: qcom: scm: add support for object invocation
config: i386-buildonly-randconfig-001-20250903 (https://download.01.org/0day-ci/archive/20250903/202509030554.WR3MNpCE-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250903/202509030554.WR3MNpCE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509030554.WR3MNpCE-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:5,
                    from drivers/firmware/qcom/qcom_scm.c:13:
   drivers/firmware/qcom/qcom_scm.c: In function 'qcom_scm_qtee_init':
>> drivers/firmware/qcom/qcom_scm.c:2208:35: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
    2208 |                 dev_err(scm->dev, "qcomtee: register failed: %d\n",
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
     154 |         dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                        ^~~~~~~
   drivers/firmware/qcom/qcom_scm.c:2208:17: note: in expansion of macro 'dev_err'
    2208 |                 dev_err(scm->dev, "qcomtee: register failed: %d\n",
         |                 ^~~~~~~
   drivers/firmware/qcom/qcom_scm.c:2208:63: note: format string is defined here
    2208 |                 dev_err(scm->dev, "qcomtee: register failed: %d\n",
         |                                                              ~^
         |                                                               |
         |                                                               int
         |                                                              %ld


vim +2208 drivers/firmware/qcom/qcom_scm.c

  2188	
  2189	static void qcom_scm_qtee_init(struct qcom_scm *scm)
  2190	{
  2191		struct platform_device *qtee_dev;
  2192		u64 result, response_type;
  2193		int ret;
  2194	
  2195		/*
  2196		 * Probe for smcinvoke support. This will fail due to invalid buffers,
  2197		 * but first, it checks whether the call is supported in QTEE syscall
  2198		 * handler. If it is not supported, -EIO is returned.
  2199		 */
  2200		ret = qcom_scm_qtee_invoke_smc(0, 0, 0, 0, &result, &response_type);
  2201		if (ret == -EIO)
  2202			return;
  2203	
  2204		/* Setup QTEE interface device. */
  2205		qtee_dev = platform_device_register_data(scm->dev, "qcomtee",
  2206							 PLATFORM_DEVID_NONE, NULL, 0);
  2207		if (IS_ERR(qtee_dev)) {
> 2208			dev_err(scm->dev, "qcomtee: register failed: %d\n",
  2209				PTR_ERR(qtee_dev));
  2210			return;
  2211		}
  2212	
  2213		ret = devm_add_action_or_reset(scm->dev, qcom_scm_qtee_free, qtee_dev);
  2214		if (ret)
  2215			dev_err(scm->dev, "qcomtee: add action failed: %d\n", ret);
  2216	}
  2217	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki