linux-kernel - Re: [PATCH v2] net/tls: support maximum record size limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca3313461aac2a7e6e81c2dff16ea8fcd5caa607.camel@wdc.com>
Date: Tue, 2 Sep 2025 22:05:10 +0000
From: Wilfred Mallawa <wilfred.mallawa@....com>
To: "horms@...nel.org" <horms@...nel.org>
CC: "corbet@....net" <corbet@....net>, "dlemoal@...nel.org"
	<dlemoal@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, Alistair
 Francis <Alistair.Francis@....com>, "john.fastabend@...il.com"
	<john.fastabend@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] net/tls: support maximum record size limit

On Tue, 2025-09-02 at 12:40 +0100, Simon Horman wrote:
> 
[snip]
> Hi Wilfred,
> 
> I'll leave review of this approach to others.
> But in the meantime I wanted to pass on a minor problem I noticed in
> the code
> 
> > diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
> > index bac65d0d4e3e..9f9359f591d3 100644
> > --- a/net/tls/tls_sw.c
> > +++ b/net/tls/tls_sw.c
> > @@ -1033,6 +1033,7 @@ static int tls_sw_sendmsg_locked(struct sock
> > *sk, struct msghdr *msg,
> >  	unsigned char record_type = TLS_RECORD_TYPE_DATA;
> >  	bool is_kvec = iov_iter_is_kvec(&msg->msg_iter);
> >  	bool eor = !(msg->msg_flags & MSG_MORE);
> > +	u16 record_size_limit;
> >  	size_t try_to_copy;
> >  	ssize_t copied = 0;
> >  	struct sk_msg *msg_pl, *msg_en;
> > @@ -1058,6 +1059,9 @@ static int tls_sw_sendmsg_locked(struct sock
> > *sk, struct msghdr *msg,
> >  		}
> >  	}
> >  
> > +	record_size_limit = tls_ctx->record_size_limit ?
> > +			    tls_ctx->record_size_limit :
> > TLS_MAX_PAYLOAD_SIZE;
> > +
> >  	while (msg_data_left(msg)) {
> >  		if (sk->sk_err) {
> >  			ret = -sk->sk_err;
> 
> record_size_limit is set but otherwise unused.
> Did you forget to add something here?
> 
> If not, please remove record_size_limit from this function.
Hey Simon,

Yes, this is an error. I will fixup. Thank you.

Regards,
Wilfred