[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <willemdebruijn.kernel.2c7a6dc71163b@gmail.com>
Date: Tue, 02 Sep 2025 18:49:26 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Breno Leitao <leitao@...ian.org>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Simon Horman <horms@...nel.org>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Clark Williams <clrkwllms@...nel.org>,
Steven Rostedt <rostedt@...dmis.org>
Cc: netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-rt-devel@...ts.linux.dev,
kernel-team@...a.com,
efault@....de,
calvin@...nvd.org,
Breno Leitao <leitao@...ian.org>
Subject: Re: [PATCH 3/7] netpoll: Move netpoll_cleanup implementation to
netconsole
Breno Leitao wrote:
> Shift the definition of netpoll_cleanup() from netpoll core to the
> netconsole driver, updating all relevant file references. This change
> centralizes cleanup logic alongside netconsole target management,
>
> Given netpoll_cleanup() is only called by netconsole, keep it there.
>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
What's the rationale for making this a separate patch, as the
previous patch also moves the other netconsole specific code from
netpoll.c to netconsole.c?
And/or consider updating prefix from netpoll_.. to netconsole_..
Just two considerations. Not blockers.
Reviewed-by: Willem de Bruijn <willemb@...gle.com>
Powered by blists - more mailing lists