linux-kernel - Re: [PATCH v5] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANBuOYrcdzDytx0f=ZbpMujcNGn8RLGZwOJBE8FzPsGtt1y9iQ@mail.gmail.com>
Date: Wed, 3 Sep 2025 00:55:25 +0200
From: Jihed Chaibi <jihed.chaibi.dev@...il.com>
To: Andreas Kemnade <andreas@...nade.info>
Cc: lee@...nel.org, krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org, 
	ukleinek@...nel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pwm@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v5] dt-bindings: mfd: twl: Add missing sub-nodes for
 TWL4030 & TWL603x

> > +                  - ti,twl4030-power-idle-osc-off
>
> this allows quite weird combinations like
>  "ti,twl4030-power-idle", "ti,twl4030-power-idle".
> I would propose to rather clean this up to things used in
> twl4030-power.c and at the same time available in dts, also
> taking the brush in the dts. I do not expect that these specific
> compatibles are in use anywhere. I looked around earlier.
>
> Regards,
> Andreas

Hi Andreas,

Thank you for the feedback. I've done a deeper investigation into
the 'power:compatible' strings to see if the schema could be made
stricter.

While cleaning up the list, I found an existing DTSI file
(logicpd-torpedo-som.dtsi) that uses the combination:
'compatible = "ti,twl4030-power-idle-osc-off", "ti,twl4030-power-idle";'

Since this "idle, idle" combination is already in use, it seems we
cannot make the schema stricter without breaking this existing
board.

I can prepare a v6 that drops the obsolete 'beagleboard-xm' and
'n900', (which are not used by any driver) but keeps the fallback
logic permissive to avoid a regression.

Does this sound like the right path forward?
Cheers,