linux-kernel - Re: [PATCH 6/7] netpoll: Move find_skb() to netconsole and make it static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <willemdebruijn.kernel.7e2624ba7462@gmail.com>
Date: Tue, 02 Sep 2025 19:07:26 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Breno Leitao <leitao@...ian.org>, 
 Andrew Lunn <andrew+netdev@...n.ch>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>, 
 Clark Williams <clrkwllms@...nel.org>, 
 Steven Rostedt <rostedt@...dmis.org>
Cc: netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 linux-rt-devel@...ts.linux.dev, 
 kernel-team@...a.com, 
 efault@....de, 
 calvin@...nvd.org, 
 Breno Leitao <leitao@...ian.org>
Subject: Re: [PATCH 6/7] netpoll: Move find_skb() to netconsole and make it
 static

Breno Leitao wrote:
> Complete the SKB pool management refactoring by moving find_skb() from
> netpoll core to netconsole driver, making it a static function.
> 
> This is the final step in removing SKB pool management from the generic
> netpoll infrastructure. With this change:
> 
> 1. Netpoll core is now purely transmission-focused: Contains only
>    the essential netpoll_send_skb() function for low-level packet
>    transmission, with no knowledge of SKB allocation or pool management.
> 
> 2. Complete encapsulation in netconsole: All SKB lifecycle
>    management (allocation, pool handling, packet construction) is now
>    contained within the netconsole driver where it belongs.
> 
> 3. Cleaner API surface: Removes the last SKB management export from
>    netpoll, leaving only zap_completion_queue() as a utility function
>    and netpoll_send_skb() for transmission.
> 
> 4. Better maintainability: Changes to SKB allocation strategies or
>    pool management can now be made entirely within netconsole without
>    affecting the core netpoll infrastructure.
> 
> The find_skb() function is made static since it's now only used within
> netconsole.c for its internal SKB allocation needs.
> 
> This completes the architectural cleanup that separates generic netpoll
> transmission capabilities from console-specific resource management.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>