| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202509021425.HuVijyYS-lkp@intel.com>
Date: Tue, 2 Sep 2025 14:30:19 +0800
From: kernel test robot <lkp@...el.com>
To: Zhongqiu Han <zhongqiu.han@....qualcomm.com>, alim.akhtar@...sung.com,
avri.altman@....com, bvanassche@....org,
James.Bottomley@...senpartnership.com, martin.petersen@...cle.com
Cc: oe-kbuild-all@...ts.linux.dev, peter.wang@...iatek.com,
tanghuan@...o.com, liu.song13@....com.cn, quic_nguyenb@...cinc.com,
viro@...iv.linux.org.uk, huobean@...il.com, adrian.hunter@...el.com,
can.guo@....qualcomm.com, ebiggers@...nel.org,
neil.armstrong@...aro.org, angelogioacchino.delregno@...labora.com,
quic_narepall@...cinc.com, quic_mnaresh@...cinc.com,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
nitin.rawat@....qualcomm.com, ziqi.chen@....qualcomm.com,
zhongqiu.han@....qualcomm.com
Subject: Re: [PATCH] scsi: ufs: core: Fix data race in CPU latency PM QoS
request handling
Hi Zhongqiu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.17-rc4 next-20250901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zhongqiu-Han/scsi-ufs-core-Fix-data-race-in-CPU-latency-PM-QoS-request-handling/20250901-165540
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/r/20250901085117.86160-1-zhongqiu.han%40oss.qualcomm.com
patch subject: [PATCH] scsi: ufs: core: Fix data race in CPU latency PM QoS request handling
config: arc-randconfig-002-20250902 (https://download.01.org/0day-ci/archive/20250902/202509021425.HuVijyYS-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 9.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250902/202509021425.HuVijyYS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509021425.HuVijyYS-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/ufs/core/ufshcd.c: In function 'ufshcd_pm_qos_init':
>> drivers/ufs/core/ufshcd.c:1052:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
1052 | if (hba->pm_qos_enabled)
| ^~
drivers/ufs/core/ufshcd.c:1054:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
1054 | return;
| ^~~~~~
drivers/ufs/core/ufshcd.c: In function 'ufshcd_pm_qos_exit':
drivers/ufs/core/ufshcd.c:1072:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
1072 | if (!hba->pm_qos_enabled)
| ^~
drivers/ufs/core/ufshcd.c:1074:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
1074 | return;
| ^~~~~~
drivers/ufs/core/ufshcd.c: In function 'ufshcd_pm_qos_update':
drivers/ufs/core/ufshcd.c:1090:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
1090 | if (!hba->pm_qos_enabled)
| ^~
drivers/ufs/core/ufshcd.c:1092:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
1092 | return;
| ^~~~~~
vim +/if +1052 drivers/ufs/core/ufshcd.c
7a3e97b0dc4bba drivers/scsi/ufs/ufshcd.c Santosh Yaraganavi 2012-02-29 1043
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1044 /**
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1045 * ufshcd_pm_qos_init - initialize PM QoS request
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1046 * @hba: per adapter instance
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1047 */
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1048 void ufshcd_pm_qos_init(struct ufs_hba *hba)
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1049 {
5824c3647e1ad8 drivers/ufs/core/ufshcd.c Zhongqiu Han 2025-09-01 1050 mutex_lock(&hba->pm_qos_mutex);
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1051
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 @1052 if (hba->pm_qos_enabled)
5824c3647e1ad8 drivers/ufs/core/ufshcd.c Zhongqiu Han 2025-09-01 1053 mutex_unlock(&hba->pm_qos_mutex);
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1054 return;
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1055
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1056 cpu_latency_qos_add_request(&hba->pm_qos_req, PM_QOS_DEFAULT_VALUE);
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1057
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1058 if (cpu_latency_qos_request_active(&hba->pm_qos_req))
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1059 hba->pm_qos_enabled = true;
5824c3647e1ad8 drivers/ufs/core/ufshcd.c Zhongqiu Han 2025-09-01 1060
5824c3647e1ad8 drivers/ufs/core/ufshcd.c Zhongqiu Han 2025-09-01 1061 mutex_unlock(&hba->pm_qos_mutex);
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1062 }
2777e73fc154e2 drivers/ufs/core/ufshcd.c Maramaina Naresh 2023-12-19 1063
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists