linux-kernel - Re: [PATCH net-next] net: selftests: clean up tools/testing/selftests/net/lib/py/utils.py

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250902072657.GP15473@horms.kernel.org>
Date: Tue, 2 Sep 2025 08:26:57 +0100
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: selftests: clean up
 tools/testing/selftests/net/lib/py/utils.py

On Mon, Sep 01, 2025 at 03:00:07AM -0700, Breno Leitao wrote:
> This patch improves the utils.py module by removing unused imports
> (errno, random), simplifying the fd_read_timeout() function by
> eliminating unnecessary else clause, and cleaning up code style in the
> defer class constructor.
> 
> Additionally, it renames the parameter in rand_port() from 'type' to
> 'stype' to avoid shadowing the built-in Python name 'type', improving
> code clarity and preventing potential issues.
> 
> These changes enhance code readability and maintainability without
> affecting functionality.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Simon Horman <horms@...nel.org>