linux-kernel - Re: [PATCH v3 3/7] dt-bindings: phy: rockchip-inno-csi-dphy: add rk3588 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250902-piquant-secret-moose-06c4b6@kuoka>
Date: Tue, 2 Sep 2025 09:55:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Michael Riesch <michael.riesch@...labora.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Vinod Koul <vkoul@...nel.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Kever Yang <kever.yang@...k-chips.com>, Jagan Teki <jagan@...rulasolutions.com>, 
	Sebastian Reichel <sebastian.reichel@...labora.com>, Diederik de Haas <didi.debian@...ow.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Collabora Kernel Team <kernel@...labora.com>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v3 3/7] dt-bindings: phy: rockchip-inno-csi-dphy: add
 rk3588 variant

On Mon, Sep 01, 2025 at 10:47:44PM +0200, Michael Riesch wrote:
> The Rockchip RK3588 variant of the CSI-2 DPHY features two reset lines.
> Add the variant and allow for the additional reset.
> 
> Signed-off-by: Michael Riesch <michael.riesch@...labora.com>
> ---
>  .../bindings/phy/rockchip-inno-csi-dphy.yaml       | 50 +++++++++++++++++++++-
>  1 file changed, 49 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
> index 9ad72518e6da..e37c9fd74788 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
> @@ -21,6 +21,7 @@ properties:
>        - rockchip,rk3326-csi-dphy
>        - rockchip,rk3368-csi-dphy
>        - rockchip,rk3568-csi-dphy
> +      - rockchip,rk3588-csi-dphy
>  
>    reg:
>      maxItems: 1
> @@ -40,11 +41,15 @@ properties:
>  
>    resets:
>      items:
> -      - description: exclusive PHY reset line
> +      - description: APB reset line
> +      - description: PHY reset line

That's changing the order, before first was the phy....

> +    minItems: 1
>  
>    reset-names:
>      items:
>        - const: apb
> +      - const: phy

Although here first was apb? Quite confusing.

Anyway "phy" reset for "phy" is pretty non-informative, please give some
useful name.

> +    minItems: 1

Best regards,
Krzysztof