linux-kernel - Re: [PATCH 1/3] ASoC: dt-bindings: everest,es8316: Document routing strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250902-cooperative-mink-from-asgard-b7ed63@kuoka>
Date: Tue, 2 Sep 2025 09:57:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: Jihed Chaibi <jihed.chaibi.dev@...il.com>, linux-sound@...r.kernel.org, 
	lgirdwood@...il.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	drake@...lessm.com, katsuhiro@...suster.net, matteomartelli3@...il.com, 
	zhoubinbin@...ngson.cn, KCHSU0@...oton.com, patches@...nsource.cirrus.com, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: everest,es8316: Document routing
 strings

On Tue, Aug 12, 2025 at 12:05:55PM +0100, Mark Brown wrote:
> On Tue, Aug 12, 2025 at 09:40:20AM +0200, Krzysztof Kozlowski wrote:
> > On 09/08/2025 17:18, Jihed Chaibi wrote:
> > > The es8316 driver defines several DAPM widget names that are used for
> > > audio routing in the device tree. However, these strings are not
> > > documented in the binding file.
> 
> > > This forces developers to read the C source to discover the valid
> > > names, which can be inefficient and error-prone.
> 
> > Reading free form text is as inefficient and error-prone as reading the
> > driver.
> 
> On the one hand, yes.  On the other hand this is better than what we had
> before so seems useful.  Ideally at some point someone will add a
> binding for this but that's a much bigger piece of work.

Fair enough. Jihed, please send v2 with descriptions referring rather to
pins or device, instead of the driver. Even though you took them from
driver, people would just copy-paste this description later for their
new drivers...

Best regards,
Krzysztof