lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5f94830d-8ad0-4abb-a109-bad88b4a9090@ti.com>
Date: Tue, 2 Sep 2025 14:03:46 +0530
From: Santhosh Kumar K <s-k6@...com>
To: Paresh Bhagat <p-bhagat@...com>, Nishanth Menon <nm@...com>
CC: <vigneshr@...com>, <praneeth@...com>, <kristo@...nel.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <khasim@...com>, <v-singh1@...com>,
        <afd@...com>, <bb@...com>, <s-k6@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62d2-evm: Add support for OSPI flash

Hello Paresh,

On 23/08/25 09:03, Paresh Bhagat wrote:
> Hi Nishanth,
> 
> 
> On 23/08/25 00:00, Nishanth Menon wrote:
>> On 14:33-20250813, Paresh Bhagat wrote:
>>> AM62D2 EVM has S28HS512T 64 MiB Octal SPI NOR flash connected to the
>>> OSPI interface. Add support for the flash and describe the partition
>>> information as per bootloader.
>>>
>>> Signed-off-by: Paresh Bhagat <p-bhagat@...com>

Thanks for the patch.

>>> ---
>>> Boot logs
>>> https://gist.github.com/paresh-bhagat12/262d8c64e692d22c4e48363d246fb083
>> We already have issues with am62d that needs fixing:
>> cpu cpu0: _of_add_opp_table_v2: no supported OPPs
>> cpu cpu0: OPP table can't be empty
>>
>> and
>>
>> Please enable defconfig for this device
>> arch/arm64/boot/dts/ti/k3-am62d2-evm.dts:       typec_pd0: usb-power- 
>> controller@3f {
>>
>> We can look at adding features for am62d after the above are done.
> 
> 
> The above fixes are now posted in upstream.

The patch seems fine wrt the SPI changes made. Good to go!

Reviewed-by: Santhosh Kumar K <s-k6@...com>

> 
> Thanks
>>> Tech Ref Manual-https://www.ti.com/lit/pdf/sprujd4
>>> Schematics Link-https://www.ti.com/lit/zip/sprcal5
>>>
>>>   arch/arm64/boot/dts/ti/k3-am62d2-evm.dts | 86 ++++++++++++++++++++++++
>>>   1 file changed, 86 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts b/arch/arm64/ 
>>> boot/dts/ti/k3-am62d2-evm.dts
>>> index daea18b0bc61..aa943ef52fb5 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
>>> @@ -25,6 +25,7 @@ aliases {
>>>           rtc0 = &wkup_rtc0;
>>>           ethernet0 = &cpsw_port1;
>>>           ethernet1 = &cpsw_port2;
>>> +        spi0 = &ospi0;
>>>       };
>>>       chosen {
>>> @@ -367,6 +368,26 @@ usr_led_pins_default: usr-led-default-pins {
>>>               AM62DX_IOPAD(0x0244, PIN_INPUT, 7) /* (D18) 
>>> MMC1_SDWP.GPIO1_49 */
>>>           >;
>>>       };
>>> +
>>> +    ospi0_pins_default: ospi0-default-pins {
>>> +        pinctrl-single,pins = <
>>> +            AM62DX_IOPAD(0x0000, PIN_OUTPUT, 0) /* (L22) OSPI0_CLK */
>>> +            AM62DX_IOPAD(0x002c, PIN_OUTPUT, 0) /* (H21) OSPI0_CSn0 */
>>> +            AM62DX_IOPAD(0x0030, PIN_OUTPUT, 0) /* (G19) OSPI0_CSn1 */
>>> +            AM62DX_IOPAD(0x0034, PIN_OUTPUT, 0) /* (K20) OSPI0_CSn2 */
>>> +            AM62DX_IOPAD(0x0038, PIN_OUTPUT, 0) /* (G20) OSPI0_CSn3 */
>>> +            AM62DX_IOPAD(0x000c, PIN_INPUT, 0) /* (J21) OSPI0_D0 */
>>> +            AM62DX_IOPAD(0x0010, PIN_INPUT, 0) /* (J18) OSPI0_D1 */
>>> +            AM62DX_IOPAD(0x0014, PIN_INPUT, 0) /* (J19) OSPI0_D2 */
>>> +            AM62DX_IOPAD(0x0018, PIN_INPUT, 0) /* (H18) OSPI0_D3 */
>>> +            AM62DX_IOPAD(0x001c, PIN_INPUT, 0) /* (K21) OSPI0_D4 */
>>> +            AM62DX_IOPAD(0x0020, PIN_INPUT, 0) /* (H19) OSPI0_D5 */
>>> +            AM62DX_IOPAD(0x0024, PIN_INPUT, 0) /* (J20) OSPI0_D6 */
>>> +            AM62DX_IOPAD(0x0028, PIN_INPUT, 0) /* (J22) OSPI0_D7 */
>>> +            AM62DX_IOPAD(0x0008, PIN_INPUT, 0) /* (L21) OSPI0_DQS */
>>> +        >;
>>> +        bootph-all;
>>> +    };
>>>   };
>>>   &mcu_gpio0 {
>>> @@ -613,3 +634,68 @@ &c7x_0 {
>>>   &main_rti4 {
>>>       status = "reserved";
>>>   };
>>> +
>>> +&fss {
>>> +    status = "okay";
>>> +};
>>> +
>>> +&ospi0 {
>>> +    pinctrl-names = "default";
>>> +    pinctrl-0 = <&ospi0_pins_default>;
>>> +    status = "okay";
>>> +
>>> +    flash@0{
>>> +        compatible = "jedec,spi-nor";
>>> +        reg = <0x0>;
>>> +        spi-tx-bus-width = <8>;
>>> +        spi-rx-bus-width = <8>;
>>> +        spi-max-frequency = <25000000>;
>>> +        cdns,tshsl-ns = <60>;
>>> +        cdns,tsd2d-ns = <60>;
>>> +        cdns,tchsh-ns = <60>;
>>> +        cdns,tslch-ns = <60>;
>>> +        cdns,read-delay = <4>;
>>> +
>>> +        partitions {
>>> +            compatible = "fixed-partitions";
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +
>>> +            partition@0 {
>>> +                label = "ospi.tiboot3";
>>> +                reg = <0x0 0x80000>;
>>> +            };
>>> +
>>> +            partition@...00 {
>>> +                label = "ospi.tispl";
>>> +                reg = <0x80000 0x200000>;
>>> +            };
>>> +
>>> +            partition@...000 {
>>> +                label = "ospi.u-boot";
>>> +                reg = <0x280000 0x400000>;
>>> +            };
>>> +
>>> +            partition@...000 {
>>> +                label = "ospi.env";
>>> +                reg = <0x680000 0x40000>;
>>> +            };
>>> +
>>> +            partition@...000 {
>>> +                label = "ospi.env.backup";
>>> +                reg = <0x6c0000 0x40000>;
>>> +            };
>>> +
>>> +            partition@...000 {
>>> +                label = "ospi.rootfs";
>>> +                reg = <0x800000 0x37c0000>;
>>> +            };
>>> +
>>> +            partition@...0000 {
>>> +                label = "ospi.phypattern";
>>> +                reg = <0x3fc0000 0x40000>;
>>> +                bootph-all;
>>> +            };
>>> +        };
>>> +    };
>>> +};
>>> -- 
>>> 2.34.1
>>>
>>>


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ