linux-kernel - Re: [PATCH v2 1/2] arm64: dts: ti: k3-am62a-main: Fix pinctrl properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77edd9c0-9bfe-4963-8149-51c819cce022@ti.com>
Date: Tue, 2 Sep 2025 14:22:02 +0530
From: s-vadapalli <s-vadapalli@...com>
To: Paresh Bhagat <p-bhagat@...com>
CC: <nm@...com>, <vigneshr@...com>, <praneeth@...com>, <kristo@...nel.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <khasim@...com>, <v-singh1@...com>,
        <afd@...com>, <bb@...com>, <s-vadapalli@...com>
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: k3-am62a-main: Fix pinctrl
 properties

On Sat, Aug 23, 2025 at 08:53:03AM +0530, Paresh Bhagat wrote:
> From: Vibhore Vardhan <vibhore@...com>
> 
> Correct reg length to match end address - start address for main

nitpick: s/reg/register

I assume that you are implying "end address - start address" as
subtracting the "start address" from the "end address" to get the
length. This description might not be required given that you are
stating the 'last physical address for the main pad configuration
registers' below. You might rephrase it to indicate that the main pad
configuration register region starts with the
MAIN_PADCFG_CTRL_MMR_CFG0_PADCONFIG0 register having the address of
0x000f4000 and the region ends with the
MAIN_PADCFG_CTRL_MMR_CFG0_PADCONFIG150 register having the address of
0x000f4258, as a result of which, the length of the region is 0x25c
instead of 0x2ac.

> PADCFG registers. The last physical address for the main pad
> configuration registers (MAIN_PADCFG_CTRL_MMR_CFG0_PADCONFIG150) is
> 0x000f4258. Adding 4 bytes gives 0x000f425c, so the size in device
> tree should be defined as 0x25c instead of 0x2ac.
> 
> Reference Docs
> TRM (AM62A) - https://www.ti.com/lit/ug/spruj16b/spruj16b.pdf
> TRM (AM62D) - https://www.ti.com/lit/ug/sprujd4/sprujd4.pdf
> 
> Fixes: 5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Vibhore Vardhan <vibhore@...com>
> Signed-off-by: Paresh Bhagat <p-bhagat@...com>

[...]

Regards,
Siddharth.