[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250902-daft-pompous-angelfish-459c6e@sudeepholla>
Date: Tue, 2 Sep 2025 10:27:11 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Artem Shimko <artyom.shimko@...il.com>
Cc: Cristian Marussi <cristian.marussi@....com>, arm-scmi@...r.kernel.org,
Sudeep Holla <sudeep.holla@....com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] firmware: arm_scmi: add missing spinlock
documentation
On Mon, Sep 01, 2025 at 07:12:04PM +0300, Artem Shimko wrote:
> Adds a missing comment for xfer_lock spinlock in struct scmi_xfers_info.
> The spinlock protects access to the xfer buffers and transfer allocation
> mechanism, preventing race conditions in concurrent access scenarios.
>
> Signed-off-by: Artem Shimko <artyom.shimko@...il.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index bd56a877fdfc..6828392152f4 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -76,6 +76,7 @@ static struct dentry *scmi_top_dentry;
> */
> struct scmi_xfers_info {
> unsigned long *xfer_alloc_table;
> + /* Protects access to the xfer buffers */
Thanks for your patch but this is quite obvious and I see no point in
just adding this comment.
--
Regards,
Sudeep
Powered by blists - more mailing lists