[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3005966.e9J7NaK4W3@7940hx>
Date: Tue, 02 Sep 2025 17:50:32 +0800
From: menglong.dong@...ux.dev
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: mhiramat@...nel.org, rostedt@...dmis.org, mathieu.desnoyers@...icios.com,
linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
oliver.sang@...el.com
Subject: Re: [PATCH] tracing: fprobe: fix suspicious rcu usage in fprobe_entry
On 2025/9/2 17:17 Herbert Xu <herbert@...dor.apana.org.au> write:
> Menglong Dong <dongml2@...natelecom.cn> wrote:
> >
> > diff --git a/kernel/trace/fprobe.c b/kernel/trace/fprobe.c
> > index fb127fa95f21..fece0f849c1c 100644
> > --- a/kernel/trace/fprobe.c
> > +++ b/kernel/trace/fprobe.c
> > @@ -269,7 +269,9 @@ static int fprobe_entry(struct ftrace_graph_ent *trace, struct fgraph_ops *gops,
> > if (WARN_ON_ONCE(!fregs))
> > return 0;
> >
> > + rcu_read_lock();
> > head = rhltable_lookup(&fprobe_ip_table, &func, fprobe_rht_params);
> > + rcu_read_unlock();
> > reserved_words = 0;
> > rhl_for_each_entry_rcu(node, pos, head, hlist) {
> > if (node->addr != func)
>
> Actually this isn't quite right. I know that it is a false-positive
> so that it's actually safe, but if you're going to mark it with
> rcu_read_lock, it should cover both the lookup as well as the
> dereference which happens in the loop rhl_for_each_entry_rcu.
Yeah, I understand. The rcu_read_lock() here is totally used to
suppress the suspicious rcu usage warning, not for the protection.
So I used it just for the rhltable_lookup() to reduce the impact.
Maybe I should add some comment for it.
This is the easiest way to suppress the warning, but not the best,
as it can introduce addition overhead when PREEMPT is enabled.
As Masami said, maybe we can use guard(rcu)() here to obtain
better code readability.
It seems that it's hard to think of a way to suppress the warning
without holding the rcu_read_lock :/
Thanks!
Menglong Dong
>
> Thanks,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
>
Powered by blists - more mailing lists