linux-kernel - Re: [PATCH] hisi_acc_vfio_pci: Fix reference leak in hisi_acc_vfio_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2adf26f3-c40a-4244-99ac-6544a0fb1d06@web.de>
Date: Tue, 2 Sep 2025 13:47:55 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Miaoqian Lin <linmq006@...il.com>, kvm@...r.kernel.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Alex Williamson <alex.williamson@...hat.com>, Jason Gunthorpe
 <jgg@...pe.ca>, Kevin Tian <kevin.tian@...el.com>,
 Longfang Liu <liulongfang@...wei.com>,
 Shameer Kolothum <shameerkolothum@...il.com>,
 Yishai Hadas <yishaih@...dia.com>
Subject: Re: [PATCH] hisi_acc_vfio_pci: Fix reference leak in
 hisi_acc_vfio_debug_init

> The debugfs_lookup() function returns a dentry with an increased reference
> count that must be released by calling dput().

* See also:
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n94

* Would you like to complete the object clean-up by using a goto chain?

* How do you think about to increase the application of scope-based resource management?
  https://elixir.bootlin.com/linux/v6.17-rc4/source/include/linux/pci.h#L1208

* Would it be helpful to append parentheses to the function name
  in the summary phrase?


Regards,
Markus