linux-kernel - Re: [PATCH v2 1/2] iio: humditiy: hdc3020: fix units for temperature and humidity measurement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCIAUP552XK1.10SMMK7H3VAVH@gmail.com>
Date: Tue, 02 Sep 2025 20:05:47 +0800
From: "Javier Carrasco" <javier.carrasco.cruz@...il.com>
To: <dimitri.fedrau@...bherr.com>, "Li peiyu" <579lpy@...il.com>, "Jonathan
 Cameron" <jic23@...nel.org>, "David Lechner" <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>, "Andy Shevchenko"
 <andy@...nel.org>, "Dimitri Fedrau" <dima.fedrau@...il.com>
Cc: "Jonathan Cameron" <Jonathan.Cameron@...wei.com>,
 <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Chris Lesiak"
 <chris.lesiak@...orbio.com>
Subject: Re: [PATCH v2 1/2] iio: humditiy: hdc3020: fix units for
 temperature and humidity measurement

On Tue Sep 2, 2025 at 1:51 AM CST, Dimitri Fedrau via B4 Relay wrote:
> From: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
>
> According to the ABI the units after application of scale and offset are
> milli degrees for temperature measurements and milli percent for relative
> humidity measurements. Currently the resulting units are degree celsius for
> temperature measurements and percent for relative humidity measurements.
> Change scale factor to fix this issue.
>
> Fixes: c9180b8e39be ("iio: humidity: Add driver for ti HDC302x humidity sensors")
> Reported-by: Chris Lesiak <chris.lesiak@...orbio.com>
> Suggested-by: Chris Lesiak <chris.lesiak@...orbio.com>
> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
> ---
>  drivers/iio/humidity/hdc3020.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
> index ffb25596d3a8bad01d1f84a9a972561266f65d76..8aa567d9aded9cab461f1f905b6b5ada721ba2f0 100644
> --- a/drivers/iio/humidity/hdc3020.c
> +++ b/drivers/iio/humidity/hdc3020.c
> @@ -301,9 +301,9 @@ static int hdc3020_read_raw(struct iio_dev *indio_dev,
>  	case IIO_CHAN_INFO_SCALE:
>  		*val2 = 65536;
>  		if (chan->type == IIO_TEMP)
> -			*val = 175;
> +			*val = 175 * MILLI;
>  		else
> -			*val = 100;
> +			*val = 100 * MILLI;
>  		return IIO_VAL_FRACTIONAL;
>  
>  	case IIO_CHAN_INFO_OFFSET:

Reviewed-by: Javier Carrasco <javier.carrasco.cruz@...il.com>