linux-kernel - Re: [PATCH 03/10] gpu: nova-core: gsp: Create wpr metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCJ6UUWUC9JI.MKBSK8M1E6J3@nvidia.com>
Date: Wed, 03 Sep 2025 22:10:35 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Alexandre Courbot" <acourbot@...dia.com>, "Alistair Popple"
 <apopple@...dia.com>
Cc: <dri-devel@...ts.freedesktop.org>, <dakr@...nel.org>, "Miguel Ojeda"
 <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun Feng"
 <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "David
 Airlie" <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Maarten
 Lankhorst" <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard"
 <mripard@...nel.org>, "Thomas Zimmermann" <tzimmermann@...e.de>, "John
 Hubbard" <jhubbard@...dia.com>, "Joel Fernandes" <joelagnelf@...dia.com>,
 "Timur Tabi" <ttabi@...dia.com>, <linux-kernel@...r.kernel.org>,
 <nouveau@...ts.freedesktop.org>, "Nouveau"
 <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH 03/10] gpu: nova-core: gsp: Create wpr metadata

On Wed Sep 3, 2025 at 9:51 PM JST, Alexandre Courbot wrote:
>> And it's all tightly coupled anyway - for example the Gsp boot arguments require some
>> command queue offsets which are all pretty specific to the Gsp implementation.
>> Ie. we can't define some nice public API in the Gsp crate for "getting arguments
>> required for booting Gsp" without that just being "here is a struct containing
>> all the fields that must be packed into the Gsp arguments for this version",
>> which at that point may as well just be the actual struct itself right?
>
> Which particular structure are you refering to?

Ah, I guess that was about `GspArgumentsCached` and the message queue's
`get_cmdq_offsets` method. For this I guess we can just have a

    fn new(cmdq: &GspCmdq) -> Self

constructor for `GspArgumentsCached` which grabs the information it
needs from the queue and initializes itself. You would need to have this
code anyway, it's just a matter of where we put it - inside a function
of `gsp.rs`, or as a reusable (and easily replacable) constructor.