linux-kernel - Re: [PATCH RFC v3 05/15] block: factor out a helper bio_submit_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLhCaMTsQ5uuLB4m@infradead.org>
Date: Wed, 3 Sep 2025 06:28:08 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Yu Kuai <yukuai1@...weicloud.com>, hch@...radead.org, colyli@...nel.org,
	hare@...e.de, dlemoal@...nel.org, tieren@...as.com, axboe@...nel.dk,
	tj@...nel.org, josef@...icpanda.com, song@...nel.org,
	kmo@...erainc.com, satyat@...gle.com, ebiggers@...gle.com,
	neil@...wn.name, akpm@...ux-foundation.org,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org, linux-raid@...r.kernel.org,
	yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com,
	johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC v3 05/15] block: factor out a helper
 bio_submit_split_bioset()

On Tue, Sep 02, 2025 at 10:12:23AM -0700, Bart Van Assche wrote:
> This is a good opportunity to reduce the indentation level in this
> function by adding something like this above the
> bio_submit_split_bioset() call:
> 
> if (unlikely(split_sectors == 0))
> 	return bio;

I asked Kuan not to mix functionality changes and reformatting for
the initial version.  With the new helper it doesn't matter too
much, but to be honest I also think the current flow is more readable
with the new helper anyway and it's not like there is a lot of
indentation.