linux-kernel - Re: [PATCH] net: dsa: dsa_loop: use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250903132846.h4eeqi5faqkghrzv@skbuf>
Date: Wed, 3 Sep 2025 16:28:46 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: dsa_loop: use int type to store negative error
 codes

On Wed, Sep 03, 2025 at 08:34:03PM +0800, Qianfeng Rong wrote:
> Change the 'ret' variable in dsa_loop_init() from unsigned int to int, as
> it needs to store either negative error codes or zero returned by
> mdio_driver_register().
> 
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing.  Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
> 
> No effect on runtime.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>