linux-kernel - Re: [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLhC0uPbWfTGa1Dl@infradead.org>
Date: Wed, 3 Sep 2025 06:29:54 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: hch@...radead.org, colyli@...nel.org, hare@...e.de, dlemoal@...nel.org,
	tieren@...as.com, axboe@...nel.dk, tj@...nel.org,
	josef@...icpanda.com, song@...nel.org, kmo@...erainc.com,
	satyat@...gle.com, ebiggers@...gle.com, neil@...wn.name,
	akpm@...ux-foundation.org, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	linux-raid@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com,
	yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to
 use bio_submit_split_bioset()

On Mon, Sep 01, 2025 at 11:32:11AM +0800, Yu Kuai wrote:
> +		bio = bio_submit_split_bioset(
> +				bio, zone->zone_end - bio->bi_iter.bi_sector,
> +				&mddev->bio_set);

Nit: this would be a bit more readable as:

		bio = bio_submit_split_bioset(bio,
				zone->zone_end - bio->bi_iter.bi_sector,
				&mddev->bio_set);

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>