linux-kernel - Re: [RFC 0/1] fsnotify: clear PARENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ownanwiqdhijstazux3j5jsawdyw6tcgjufk6zrejppnqyoy7d@hdqmfb4q7wpz>
Date: Wed, 3 Sep 2025 15:31:56 +0200
From: Jan Kara <jack@...e.cz>
To: Diangang Li <lidiangang@...edance.com>
Cc: jack@...e.cz, amir73il@...il.com, stephen.s.brennan@...cle.com, 
	changfengnan@...edance.com, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 0/1] fsnotify: clear PARENT_WATCHED flags lazily for v5.4

On Wed 03-09-25 17:34:12, Diangang Li wrote:
> Hi Amir, Jan, et al,
> 
> Commit `41f49be2e51a71` ("fsnotify: clear PARENT_WATCHED flags lazily")
> has resolved the softlockup in `__fsnotify_parent` when there are millions
> of negative dentries. The Linux kernel CVE team has assigned CVE-2024-47660
> to this issue[1]. I noticed that the CVE patch was only backported to the
> 5.10 stable tree, and not to 5.4. Is there any specific reason or analysis
> regarding the 5.4 branch? We have encountered this issue in our production
> environments running kernel 5.4. After manually applying and deconflicting
> this patch, the problem was resolved.
> 
> Any comments or suggestions regarding this backport would be appreciated.

I don't have any objections against including this in 5.4-stable branch.
Probably it was not applied because of some patch conflict. Feel free to
send the backport to stable@...r.kernel.org, I believe Greg will gladly
pickup the patch.

								Honza

> 
> Thanks,
> Diangang
> 
> [1]: https://lore.kernel.org/all/2024100959-CVE-2024-47660-2d61@gregkh/
> 
> Amir Goldstein (1):
>   fsnotify: clear PARENT_WATCHED flags lazily
> 
>  fs/notify/fsnotify.c             | 31 +++++++++++++++++++++----------
>  fs/notify/fsnotify.h             |  2 +-
>  fs/notify/mark.c                 | 32 +++++++++++++++++++++++++++++---
>  include/linux/fsnotify_backend.h |  8 +++++---
>  4 files changed, 56 insertions(+), 17 deletions(-)
> 
> -- 
> 2.39.5
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR