linux-kernel - Re: [PATCH 2/4] arm64: dts: st: enable ethernet1 controller on stm32mp257f-dk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9cfa9cb4-bf7e-4d48-b0cc-0726784b7462@foss.st.com>
Date: Wed, 3 Sep 2025 15:35:01 +0200
From: Gatien CHEVALLIER <gatien.chevallier@...s.st.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Coquelin
	<mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] arm64: dts: st: enable ethernet1 controller on
 stm32mp257f-dk



On 9/3/25 14:21, Andrew Lunn wrote:
>> +&ethernet1 {
>> +	pinctrl-0 = <&eth1_rgmii_pins_b>;
>> +	pinctrl-1 = <&eth1_rgmii_sleep_pins_b>;
>> +	pinctrl-names = "default", "sleep";
>> +	max-speed = <1000>;
> 
> RGMII naturally has a max-speed of 1G, so this line is pointless.
> 
> You only use max-speed when you need to restrict the system below what
> it would normally use, for example if the PCB is badly designed and
> the tracks don't support 1G, but can do 100Mbps
> 
> 	Andrew

Right, I'll simply remove these lines.

Gatien