linux-kernel - Re: [PATCH 4/5] media: staging: Drop bcm2835-camera driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <175690685574.8095.13306600513284108529@freya>
Date: Wed, 03 Sep 2025 19:10:55 +0530
From: Jai Luthra <jai.luthra@...asonboard.com>
To: Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Florian Fainelli <florian.fainelli@...adcom.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Stefan Wahren <wahrenst@....net>
Cc: linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, kernel-list@...pberrypi.com, Dave Stevenson <dave.stevenson@...pberrypi.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH 4/5] media: staging: Drop bcm2835-camera driver

Hi Stefan,

Quoting Stefan Wahren (2025-08-28 00:48:22)
> Hi Jai,
> 
> Am 27.08.25 um 08:24 schrieb Jai Luthra:
> > The bcm2835-camera driver is replaced by the V4L2 bcm2835-unicam driver
> > that is already upstream. So drop it from staging.
> AFAIK the old Raspberry Pi Camera V1 isn't supported by V4L2 
> bcm2835-unicam. Personally i'm fine with this, but this must be clear in 
> the commit message.Did you already talked to distributions like Redhat & 
> OpenSuSE about this step?

As Dave mentioned, the OV5647 should work with V4L2. I don't have a sensor
with me, but I can order one and try to get it working with the upstream
kernel separate from this series.

I did test the V2 camera module (IMX219) with my series applied on top of
upstream kernel, and capture worked fine with bcm2835-unicam, so I don't
believe V1 camera module should be an issue.

> > This also simplifies destaging of VCHIQ MMAL, by reducing the users of
> > the MMAL API (this driver is one of them).
> AFAIU this drops the only one user of VCHIQ MMAL. So please explain, why 
> we still need this API and how this should be tested?

The bcm2835-isp and bcm2835-codec are other users, which are currently only
present in the downstream Pi kernel [1].

I plan to upstream the ISP driver as a subsequent series (that was the main
motivation for this series), thus keeping the MMAL API still here.

[1] https://github.com/search?q=repo%3Araspberrypi%2Flinux%20%23include%20%22..%2Fvchiq-mmal%2F&type=code

> 
> Best regards

Thanks,
    Jai