linux-kernel - Re: [PATCH v4 0/5] media: imx8qxp: add parallel camera support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aLhJDXnz9HPGrWcp@lizhi-Precision-Tower-5810>
Date: Wed, 3 Sep 2025 09:56:29 -0400
From: Frank Li <Frank.li@....com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Rui Miguel Silva <rmfrfs@...il.com>,
	Martin Kepplinger <martink@...teo.de>,
	Purism Kernel Team <kernel@...i.sm>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>, linux-media@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Alice Yuan <alice.yuan@....com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Robert Chiras <robert.chiras@....com>,
	Zhipeng Wang <zhipeng.wang_1@....com>
Subject: Re: [PATCH v4 0/5] media: imx8qxp: add parallel camera support

On Tue, Sep 02, 2025 at 02:39:20PM +0200, Laurent Pinchart wrote:
> Hi Frank,
>
> On Tue, Sep 02, 2025 at 08:01:40AM -0400, Frank Li wrote:
> > On Tue, Aug 05, 2025 at 04:08:22AM +0300, Laurent Pinchart wrote:
> > > Hi Frank,
> > >
> > > Thank you for the patches.
> > >
> > > I've quite busy these days, and I don't believe I will have time to
> > > review this series before coming back from OSS Europe at the beginning
> > > of September. Let's see if anyone on CC could volunteer.
> >
> > Laurent Pincha
> > 	I hope you have good time at OSS.
> >
> > 	Do you have chance to review this patch?
>
> I'm going through my mail backlog, which is really big at the moment.

Understand.

> I'd like someone else to volunteer to review this series. It won't scale
> if I have to review all NXP media patches in my spare time :-/

Yes, but none volunteer review this in passed months. Expecially key
reviewer. I am reviewing i3c patches. but Not familiar v4l system yet. It
need scalable solution. I can help filter some common and simple problem
from beginning.

Frank

>
> > > On Tue, Jul 29, 2025 at 12:06:21PM -0400, Frank Li wrote:
> > > > Add parallel camera support for i.MX8 chips.
> > > >
> > > > The below patch to add new format support to test ov5640 sensor
> > > >    media: nxp: isi: add support for UYVY8_2X8 and YUYV8_2X8 bus codes
> > > >
> > > > The bindings and driver for parallel CSI
> > > >    dt-bindings: media: add i.MX parallel csi support
> > > >    media: nxp: add V4L2 subdev driver for parallel CSI
> > > >
> > > > DTS part need depend on previous MIPI CSI patches.
> > > >   https://lore.kernel.org/imx/20250522-8qxp_camera-v5-13-d4be869fdb7e@nxp.com/
> > > >
> > > >   arm64: dts: imx8: add parellel csi nodes
> > > >   arm64: dts: imx8qxp-mek: add parallel ov5640 camera support
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@....com>
> > > > ---
> > > > Changes in v4:
> > > > - remove imx93 driver support since have not camera sensor module to do test now.
> > > >   Add it later
> > > > - Add new patch
> > > >   media: v4l2-common: Add helper function v4l_get_required_align_by_bpp()
> > > > - See each patche's change log for detail.
> > > > - Link to v3: https://lore.kernel.org/r/20250708-imx8qxp_pcam-v3-0-c8533e405df1@nxp.com
> > > >
> > > > Changes in v3:
> > > > - replace CSI with CPI.
> > > > - detail change see each patch's change logs
> > > > - Link to v2: https://lore.kernel.org/r/20250703-imx8qxp_pcam-v2-0-188be85f06f1@nxp.com
> > > >
> > > > Changes in v2:
> > > > - remove patch media: nxp: isi: add support for UYVY8_2X8 and YUYV8_2X8 bus codes
> > > >   because pcif controller convert 2x8 to 1x16 to match isi's input
> > > > - rename comaptible string to fsl,imx8qxp-pcif
> > > > - See each patches's change log for detail
> > > > - Link to v1: https://lore.kernel.org/r/20250630-imx8qxp_pcam-v1-0-eccd38d99201@nxp.com
> > > >
> > > > ---
> > > > Alice Yuan (2):
> > > >       dt-bindings: media: add i.MX parallel CPI support
> > > >       media: nxp: add V4L2 subdev driver for camera parallel interface (CPI)
> > > >
> > > > Frank Li (3):
> > > >       media: v4l2-common: Add helper function v4l_get_required_align_by_bpp()
> > > >       arm64: dts: imx8: add camera parallel interface (CPI) node
> > > >       arm64: dts: imx8qxp-mek: add parallel ov5640 camera support
> > > >
> > > >  .../devicetree/bindings/media/fsl,imx93-pcif.yaml  | 126 ++++
> > > >  MAINTAINERS                                        |   2 +
> > > >  arch/arm64/boot/dts/freescale/Makefile             |   3 +
> > > >  arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi     |  13 +
> > > >  .../boot/dts/freescale/imx8qxp-mek-ov5640-cpi.dtso |  83 +++
> > > >  arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi  |  27 +
> > > >  drivers/media/platform/nxp/Kconfig                 |  11 +
> > > >  drivers/media/platform/nxp/Makefile                |   1 +
> > > >  drivers/media/platform/nxp/imx-parallel-cpi.c      | 728 +++++++++++++++++++++
> > > >  include/media/v4l2-common.h                        |  30 +
> > > >  10 files changed, 1024 insertions(+)
> > > > ---
> > > > base-commit: 37a294c6211bea9deb14bedd2dcce498935cbd4e
> > > > change-id: 20250626-imx8qxp_pcam-d851238343c3
>
> --
> Regards,
>
> Laurent Pinchart