[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL_Jsq+TcACG=vGp__tT8RE6kOjchoUSq59i=H_+qSRn-ucMkw@mail.gmail.com>
Date: Wed, 3 Sep 2025 09:05:06 -0500
From: Rob Herring <robh@...nel.org>
To: Andrew Jeffery <andrew@...econstruct.com.au>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Joel Stanley <joel@....id.au>, Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: aspeed: Fix/add I2C device vendor prefixes
On Wed, Sep 3, 2025 at 1:52 AM Andrew Jeffery
<andrew@...econstruct.com.au> wrote:
>
> On Wed, 2025-09-03 at 15:01 +0930, Andrew Jeffery wrote:
> > Hi Rob,
> >
> > On Fri, 2025-08-15 at 18:08 -0500, Rob Herring (Arm) wrote:
> > > The ASpeed DTS files have various I2C devices with missing or incorrect
> > > vendor prefixes in their compatible strings. This hasn't really mattered
> > > and doesn't impact ABI compatibility as I2C devices get matched with their
> > > vendor prefix stripped.
> > >
> > > With this, the "maxim,max31790" nodes now validate and have some
> > > warnings. Remove the spurious "#address-cells" and "#size-cells"
> > > properties to fix the warnings.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > > ---
> > > .../aspeed-bmc-arm-stardragon4800-rep2.dts | 2 +-
> > > .../dts/aspeed/aspeed-bmc-facebook-harma.dts | 8 ++-----
> > > .../aspeed/aspeed-bmc-facebook-minerva.dts | 24 +++++--------------
> > > .../aspeed/aspeed-bmc-facebook-tiogapass.dts | 2 +-
> > > .../dts/aspeed/aspeed-bmc-lenovo-hr855xg2.dts | 2 +-
> > > .../dts/aspeed/aspeed-bmc-opp-palmetto.dts | 2 +-
> > > .../boot/dts/aspeed/aspeed-bmc-quanta-s6q.dts | 4 ++--
> > > 7 files changed, 14 insertions(+), 30 deletions(-)
> > >
> >
> > I see you've applied this to your tree. Sorry for being slow on the up-
> > take, I've been focusing on other things recently. Happy to take it
> > though, if you're happy to drop it?
>
> Actually, do you mind dropping it from your tree? It conflicts with
> Krzysztof's patch that I'd already applied:
>
> https://lore.kernel.org/all/20250819131743.86905-2-krzysztof.kozlowski@linaro.org/
>
> I've applied your patch here with a note in the trailer:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/bmc/linux.git/commit/?h=aspeed/dt&id=61a913644a8c5b6c8bd9da09f78f88e50edfaeb
I've dropped it. That was inadvertent.
Rob
Powered by blists - more mailing lists