linux-kernel - Re: [PATCH v17 28/33] fs/resctrl: Introduce mbm_L3_assignments to list assignments in a group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7cfadb6-4751-4ea7-b602-896334014411@intel.com>
Date: Tue, 2 Sep 2025 19:59:41 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Babu Moger <babu.moger@....com>, <corbet@....net>, <tony.luck@...el.com>,
	<tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
	<dave.hansen@...ux.intel.com>
CC: <Dave.Martin@....com>, <james.morse@....com>, <x86@...nel.org>,
	<hpa@...or.com>, <akpm@...ux-foundation.org>, <rostedt@...dmis.org>,
	<paulmck@...nel.org>, <pawan.kumar.gupta@...ux.intel.com>, <kees@...nel.org>,
	<arnd@...db.de>, <fvdl@...gle.com>, <seanjc@...gle.com>,
	<thomas.lendacky@....com>, <yosry.ahmed@...ux.dev>, <xin@...or.com>,
	<sohil.mehta@...el.com>, <kai.huang@...el.com>, <xiaoyao.li@...el.com>,
	<peterz@...radead.org>, <mario.limonciello@....com>, <xin3.li@...el.com>,
	<perry.yuan@....com>, <chang.seok.bae@...el.com>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<peternewman@...gle.com>, <eranian@...gle.com>, <gautham.shenoy@....com>
Subject: Re: [PATCH v17 28/33] fs/resctrl: Introduce mbm_L3_assignments to
 list assignments in a group

Hi Babu,

On 8/14/25 7:25 PM, Babu Moger wrote:
> diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
> index 1de815b3a07b..af0c38206bab 100644
> --- a/Documentation/filesystems/resctrl.rst
> +++ b/Documentation/filesystems/resctrl.rst
> @@ -519,6 +519,34 @@ When the "mba_MBps" mount option is used all CTRL_MON groups will also contain:
>  	/sys/fs/resctrl/info/L3_MON/mon_features changes the input
>  	event.
>  
> +"mbm_L3_assignments":

Looking at the final documentation this addition is made in unexpected section titled:
"When the "mba_MBps" mount option is used all CTRL_MON groups will also contain:"

How about placing this description in a new section titled "When monitoring is enabled all
MON groups may also contain:" (note the word *may*) under the "mon_hw_id" description to complement
the earlier "When monitoring is enabled all MON groups will also contain:" (note the
word *will*). Open to other ideas of course.

Actual change looks good to me, just the doc placement is unexpected.

Reinette