linux-kernel - Re: [PATCH 2/7] dt-bindings: rtc: add bindings for m41t93

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9094d792-c20a-48fa-b769-5824e1f451eb@kernel.org>
Date: Wed, 3 Sep 2025 16:30:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Akhilesh Patil <akhilesh@...iitb.ac.in>, alexandre.belloni@...tlin.com,
 krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org
Cc: skhan@...uxfoundation.org, linux-rtc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 akhileshpatilvnit@...il.com
Subject: Re: [PATCH 2/7] dt-bindings: rtc: add bindings for m41t93

On 03/09/2025 16:25, Akhilesh Patil wrote:
> add DT bindings for m41t93 rtc in YAML format.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18


Please organize the patch documenting compatible (DT bindings) before
their user.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

> 
> Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>
> ---
>  .../devicetree/bindings/rtc/st,m41t93.yaml    | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rtc/st,m41t93.yaml b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> new file mode 100644
> index 000000000000..03673adc79db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/st,m41t93.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ST M41T93 RTC and compatible
> +
> +maintainers:
> +  - Alexandre Belloni <alexandre.belloni@...tlin.com>

This should not be subsystem maintainer.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - st,m41t93
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#clock-cells":

Hm? Are you sure? Nothing in the driver nor commit msg suggests that.

> +    const: 1
> +
> +allOf:
> +  - $ref: rtc.yaml
> +
> +unevaluatedProperties: false

This goes after required. See example schema.

> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      rtc@0 {
> +        spi-max-frequency = <2000000>;

Does not look tested.

> +        compatible = "st,m41t93";
> +        reg = <0>;

Please follow DTS coding style. Which property is the first in the
coding style?

Best regards,
Krzysztof