[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aLheK_1pYbirLe8R@shell.armlinux.org.uk>
Date: Wed, 3 Sep 2025 16:26:35 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net 1/2] net: phylink: add lock for serializing
concurrent pl->phydev writes with resolver
On Wed, Sep 03, 2025 at 06:23:47PM +0300, Vladimir Oltean wrote:
> @@ -2305,6 +2314,7 @@ void phylink_disconnect_phy(struct phylink *pl)
>
> phy = pl->phydev;
> if (phy) {
> + mutex_lock(&pl->phy_lock);
If we can, I think it would be better to place this a couple of lines
above and move the unlock.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists