linux-kernel - Re: [PATCH v3] Bluetooth: Fix build after header cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6afa0585-1903-4a56-b433-1087897519bf@molgen.mpg.de>
Date: Wed, 3 Sep 2025 17:29:41 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Calvin Owens <calvin@...nvd.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
 Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
 oe-kbuild-all@...ts.linux.dev, Marcel Holtmann <marcel@...tmann.org>,
 Sean Wang <sean.wang@...iatek.com>, linux-mediatek@...ts.infradead.org,
 naresh.kamboju@...aro.org
Subject: Re: [PATCH v3] Bluetooth: Fix build after header cleanup

Dear Calvin,


Thank you for the patch.

Am 03.09.25 um 16:06 schrieb Calvin Owens:
> Some Kconfig dependencies are needed after my recent cleanup, since
> the core code has its own option.
> 
> Since btmtksdio does not actually call h4_recv_buf(), move the
> definitions it uses outside the BT_HCIUART_H4 gate in hci_uart.h to
> avoid adding a dependency for btmtksdio.
> 
> The rest I touched (bpa10x, btmtkuart, and btnxpuart) do really call
> h4_recv_buf(), so the dependency is required, add it for them.
> 
> Fixes: 0e272fc7e17d ("Bluetooth: remove duplicate h4_recv_buf() in header")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508300413.OnIedvRh-lkp@intel.com/
> Signed-off-by: Calvin Owens <calvin@...nvd.org>
> ---
>   drivers/bluetooth/Kconfig    | 6 ++++++
>   drivers/bluetooth/hci_uart.h | 8 ++++----
>   2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 4ab32abf0f48..7df69ccb6600 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -312,7 +312,9 @@ config BT_HCIBCM4377
>   
>   config BT_HCIBPA10X
>   	tristate "HCI BPA10x USB driver"
> +	depends on BT_HCIUART
>   	depends on USB
> +	select BT_HCIUART_H4
>   	help
>   	  Bluetooth HCI BPA10x USB driver.
>   	  This driver provides support for the Digianswer BPA 100/105 Bluetooth
> @@ -437,8 +439,10 @@ config BT_MTKSDIO
>   
>   config BT_MTKUART
>   	tristate "MediaTek HCI UART driver"
> +	depends on BT_HCIUART
>   	depends on SERIAL_DEV_BUS
>   	depends on USB || !BT_HCIBTUSB_MTK
> +	select BT_HCIUART_H4
>   	select BT_MTK
>   	help
>   	  MediaTek Bluetooth HCI UART driver.
> @@ -483,7 +487,9 @@ config BT_VIRTIO
>   
>   config BT_NXPUART
>   	tristate "NXP protocol support"
> +	depends on BT_HCIUART
>   	depends on SERIAL_DEV_BUS
> +	select BT_HCIUART_H4
>   	select CRC32
>   	select CRC8
>   	help
> diff --git a/drivers/bluetooth/hci_uart.h b/drivers/bluetooth/hci_uart.h
> index 5ea5dd80e297..cbbe79b241ce 100644
> --- a/drivers/bluetooth/hci_uart.h
> +++ b/drivers/bluetooth/hci_uart.h
> @@ -121,10 +121,6 @@ void hci_uart_set_flow_control(struct hci_uart *hu, bool enable);
>   void hci_uart_set_speeds(struct hci_uart *hu, unsigned int init_speed,
>   			 unsigned int oper_speed);
>   
> -#ifdef CONFIG_BT_HCIUART_H4
> -int h4_init(void);
> -int h4_deinit(void);
> -
>   struct h4_recv_pkt {
>   	u8  type;	/* Packet type */
>   	u8  hlen;	/* Header length */
> @@ -162,6 +158,10 @@ struct h4_recv_pkt {
>   	.lsize = 2, \
>   	.maxlen = HCI_MAX_FRAME_SIZE \
>   
> +#ifdef CONFIG_BT_HCIUART_H4
> +int h4_init(void);
> +int h4_deinit(void);
> +
>   struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb,
>   			    const unsigned char *buffer, int count,
>   			    const struct h4_recv_pkt *pkts, int pkts_count);

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul