linux-kernel - Re: [PATCH RESEND 09/14] gpio: dwapb: use new generic GPIO chip API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLhj6xsR-NepfRx0@black.igk.intel.com>
Date: Wed, 3 Sep 2025 17:51:07 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Yinbo Zhu <zhuyinbo@...ngson.cn>,
	Hoan Tran <hoan@...amperecomputing.com>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Yang Shen <shenyang39@...wei.com>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-unisoc@...ts.infradead.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH RESEND 09/14] gpio: dwapb: use new generic GPIO chip API

On Mon, Aug 25, 2025 at 11:48:50AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Convert the driver to using the new generic GPIO chip interfaces from
> linux/gpio/generic.h.

...

> +static inline struct dwapb_gpio *to_dwapb_gpio(struct gpio_chip *gc)
> +{
> +	return container_of(to_gpio_generic_chip(gc),
> +			    struct dwapb_gpio_port, chip)->gpio;
> +}

Since it's not a macro anymore it can be done better:

	struct dwapb_gpio_port *port;

	port = container_of(to_gpio_generic_chip(gc), struct dwapb_gpio_port, chip);
	return port->gpio;

Also, have you checked the bloat-o-meter before and after, wondering if we gain
something with this.

-- 
With Best Regards,
Andy Shevchenko