linux-kernel - Re: [PATCH v6.17-rc] perf test: Checking BPF metadata collection fails on version string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLhqDDnG4Nu9-h7C@x1>
Date: Wed, 3 Sep 2025 13:17:16 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Thomas Richter <tmricht@...ux.ibm.com>,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-perf-users@...r.kernel.org, namhyung@...nel.org,
	blakejones@...gle.com, agordeev@...ux.ibm.com, gor@...ux.ibm.com,
	sumanthk@...ux.ibm.com, hca@...ux.ibm.com, japo@...ux.ibm.com
Subject: Re: [PATCH v6.17-rc] perf test: Checking BPF metadata collection
 fails on version string

On Fri, Aug 22, 2025 at 11:02:27AM -0700, Ian Rogers wrote:
> On Fri, Aug 22, 2025 at 5:26 AM Thomas Richter <tmricht@...ux.ibm.com> wrote:
> > commit edf2cadf01e8f ("perf test: add test for BPF metadata collection")

> > fails consistently on the version string check. The perf version
> > string on some of the constant integration test machines contains
> > characters with special meaning in grep's extended regular expression
> > matching algorithm. The output of perf version is:

> >  # perf version
> >  perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+git

> > and the '+' character has special meaning in egrep command.
> > Also the use of egrep is deprecated.

> > Change the perf version string check to fixed character matching
> > and get rid of egrep's warning being deprecated. Use grep -F instead.

<SNIP>

> > Fixes: edf2cadf01e8f ("perf test: add test for BPF metadata collection")
> > Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
> > Acked-by: Sumanth Korikkar <sumanthk@...ux.ibm.com>
> > Cc: Blake Jones <blakejones@...gle.com>
 
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Reviewed-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Namhyung, I think this should go into v6.17-rc.

Thanks,

- Arnaldo