linux-kernel - Re: [PATCH 4/7] netpoll: Export zap_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <v4bz7lyzs6f6mlfhvgy3p34sihu6sojwntbev3hz2sz425j76i@wanin427lov6>
Date: Wed, 3 Sep 2025 09:51:57 -0700
From: Breno Leitao <leitao@...ian.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Clark Williams <clrkwllms@...nel.org>, 
	Steven Rostedt <rostedt@...dmis.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-rt-devel@...ts.linux.dev, kernel-team@...a.com, efault@....de, calvin@...nvd.org
Subject: Re: [PATCH 4/7] netpoll: Export zap_completion_queue

On Tue, Sep 02, 2025 at 06:50:25PM -0400, Willem de Bruijn wrote:
> Breno Leitao wrote:
> >  include/linux/netpoll.h | 1 +
> >  net/core/netpoll.c      | 5 ++---
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
....
> > -static void zap_completion_queue(void)
> > +void zap_completion_queue(void)
> >  {
> >  	unsigned long flags;
> >  	struct softnet_data *sd = &get_cpu_var(softnet_data);
> > @@ -267,6 +265,7 @@ static void zap_completion_queue(void)
> >  
> >  	put_cpu_var(softnet_data);
> >  }
> > +EXPORT_SYMBOL_GPL(zap_completion_queue);
> 
> consider EXPORT_SYMBOL_NS_GPL(zap_completion_queue, "NETDEV_INTERNAL");

Thanks for the suggestion. First time I've heard about the export by
Namespace. I suppose then I need to have
`MODULE_IMPORT_NS("NETDEV_INTERNAL");` called at the caller side, right?

--breno