linux-kernel - Re: [PATCH RFC v3 02/15] block: add QUEUE_FLAG_BIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5378349f-4d00-4d3e-9834-f3ddf2e514cc@yukuai.org.cn>
Date: Thu, 4 Sep 2025 00:54:21 +0800
From: Yu Kuai <hailan@...uai.org.cn>
To: Christoph Hellwig <hch@...radead.org>, Yu Kuai <yukuai1@...weicloud.com>
Cc: colyli@...nel.org, hare@...e.de, dlemoal@...nel.org, tieren@...as.com,
 axboe@...nel.dk, tj@...nel.org, josef@...icpanda.com, song@...nel.org,
 kmo@...erainc.com, satyat@...gle.com, ebiggers@...gle.com, neil@...wn.name,
 akpm@...ux-foundation.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
 linux-raid@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com,
 yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC v3 02/15] block: add QUEUE_FLAG_BIO_ISSUE

Hi,

在 2025/9/3 21:24, Christoph Hellwig 写道:
> On Mon, Sep 01, 2025 at 11:32:07AM +0800, Yu Kuai wrote:
>>   static inline void blkcg_bio_issue_init(struct bio *bio)
>>   {
>> -	bio->issue_time_ns = blk_time_get_ns();
>> +	struct request_queue *q = bdev_get_queue(bio->bi_bdev);
>> +
>> +	if (test_bit(QUEUE_FLAG_BIO_ISSUE, &q->queue_flags))
>> +		bio->issue_time_ns = blk_time_get_ns();
>>   }
> Given that this is called on a bio and called from generic code
> and not blk-mq, the flag should in the gendisk and not the queue.
>
ok, will change to disk, and also change set/clear the flag to
enable/disable iolatency.

Thanks,
Kuai