linux-kernel - Re: [PATCH] i2c: Main i2c-*.c files and algos/ subdirectory : Fix errors and warnings generated by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fkiu64vdlndg5lvuaktao2vmvmn5al7xcpksrjmxrr4ldz5ssn@dolroldcknpd>
Date: Wed, 3 Sep 2025 18:56:12 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Cezar Chiru <chiru.cezar.89@...il.com>
Cc: wsa+renesas@...g-engineering.com, peda@...ntia.se, jdelvare@...e.com, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: Main i2c-*.c files and algos/ subdirectory : Fix
 errors and warnings generated by checkpatch

Hi Cezar,

On Sat, Aug 30, 2025 at 12:30:15PM +0300, Cezar Chiru wrote:
> Fixed some coding style errors and warnings plus some minor changes
> in code as reported by checkpatch script. The busses/ and muxes/
> subfolders will be dealt with another commit. Main changes were done
> to comments, defines of 'if' statement, swapping 'unsigned' with
> 'unsigned int' and other minor changes.
> 
> Signed-off-by: Cezar Chiru <chiru.cezar.89@...il.com>
> ---
>  drivers/i2c/Kconfig              |  2 +-
>  drivers/i2c/algos/i2c-algo-bit.c | 29 +++++++++------
>  drivers/i2c/algos/i2c-algo-pca.c | 25 +++++++++----
>  drivers/i2c/algos/i2c-algo-pcf.c | 61 ++++++++++++++++++++++----------
>  drivers/i2c/algos/i2c-algo-pcf.h | 10 +++---
>  drivers/i2c/i2c-boardinfo.c      |  2 +-
>  drivers/i2c/i2c-core-base.c      | 59 +++++++++++++++++++-----------
>  drivers/i2c/i2c-dev.c            | 47 ++++++++++++++----------
>  drivers/i2c/i2c-mux.c            |  1 +
>  drivers/i2c/i2c-slave-eeprom.c   |  2 +-
>  drivers/i2c/i2c-smbus.c          |  2 +-
>  drivers/i2c/i2c-stub.c           | 29 +++++++--------
>  12 files changed, 170 insertions(+), 99 deletions(-)

first of all, thanks for your patch, but I can't accept it.
Please split your patch in several smaller patches with single
changes.

Granularity is very important for reviews and git blame.

Thanks,
Andi