linux-kernel - Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpEUBFk6uHieHdsXoRFV+WxEgqW7LOvz1wKfrU=uKm-Uzw@mail.gmail.com>
Date: Wed, 3 Sep 2025 10:08:26 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Zi Yan <ziy@...dia.com>
Cc: Yueyang Pan <pyyjason@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Vlastimil Babka <vbabka@...e.cz>, Michal Hocko <mhocko@...e.com>, Brendan Jackman <jackmanb@...gle.com>, 
	Johannes Weiner <hannes@...xchg.org>, Vishal Moola <vishal.moola@...il.com>, 
	Shakeel Butt <shakeel.butt@...ux.dev>, Usama Arif <usamaarif642@...il.com>, linux-mm@...ck.org, 
	kernel-team@...a.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] mm/show_mem: Add trylock while printing alloc info

On Wed, Sep 3, 2025 at 9:30 AM Zi Yan <ziy@...dia.com> wrote:
>
> On 3 Sep 2025, at 7:16, Yueyang Pan wrote:
>
> > In production, show_mem() can be called concurrently from two
> > different entities, for example one from oom_kill_process()
> > another from __alloc_pages_slowpath from another kthread. This
> > patch adds a spinlock and invokes trylock before printing out the
> > kernel alloc info in show_mem(). This way two alloc info won't
> > interleave with each other, which then makes parsing easier.
> >
> > Signed-off-by: Yueyang Pan <pyyjason@...il.com>
> > ---
> >  mm/show_mem.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
>
> Acked-by: Zi Yan <ziy@...dia.com>

Acked-by: Suren Baghdasaryan <surenb@...gle.com>


>
> Best Regards,
> Yan, Zi